After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793737 - Per-device idle monitors aren't supported in Wayland
Per-device idle monitors aren't supported in Wayland
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-22 23:24 UTC by Bastien Nocera
Modified: 2018-02-27 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
idle-monitor: Per-device idle monitors aren't supported in Wayland (1.56 KB, patch)
2018-02-22 23:24 UTC, Bastien Nocera 		none Details | Review
idle-monitor: Remove per-device monitor from tests (5.04 KB, patch)
2018-02-22 23:24 UTC, Bastien Nocera 		committed Details | Review
idle-monitor: Per-device idle monitors aren't supported in Wayland (2.15 KB, patch)
2018-02-22 23:34 UTC, Bastien Nocera 		none Details | Review
idle-monitor: Per-device idle monitors aren't supported in Wayland (2.19 KB, patch)
2018-02-27 12:56 UTC, Bastien Nocera 		none Details | Review
idle-monitor: Per-device idle monitors aren't supported in Wayland (1.84 KB, patch)
2018-02-27 12:59 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2018-02-22 23:24:21 UTC 
.
Comment 1 Bastien Nocera 2018-02-22 23:24:38 UTC 
Created attachment 368806 [details] [review]
idle-monitor: Per-device idle monitors aren't supported in Wayland

So return an error.
Comment 2 Bastien Nocera 2018-02-22 23:24:44 UTC 
Created attachment 368807 [details] [review]
idle-monitor: Remove per-device monitor from tests

It's not used anywhere in the stack now that mutter handles hiding the
cursor when touchscreens are used, and doesn't work under Wayland.
Comment 3 Bastien Nocera 2018-02-22 23:34:54 UTC 
Created attachment 368809 [details] [review]
idle-monitor: Per-device idle monitors aren't supported in Wayland

So return an error.
Comment 4 Carlos Garnacho 2018-02-27 12:06:38 UTC 
Comment on attachment 368809 [details] [review]
idle-monitor: Per-device idle monitors aren't supported in Wayland

Since it's not feasible to make the current DBus API work under wayland, it makes sense to error out instead of creating a deaf monitor.
Comment 5 Carlos Garnacho 2018-02-27 12:08:45 UTC 
Comment on attachment 368807 [details] [review]
idle-monitor: Remove per-device monitor from tests

If as per the commit log there's no other users, that's probably a candidate for cleaning up on the mutter side for 3.30 :).
Comment 6 Bastien Nocera 2018-02-27 12:56:35 UTC 
Created attachment 369016 [details] [review]
idle-monitor: Per-device idle monitors aren't supported in Wayland

So return an error.
Comment 7 Bastien Nocera 2018-02-27 12:59:22 UTC 
Created attachment 369017 [details] [review]
idle-monitor: Per-device idle monitors aren't supported in Wayland

So return an error.
Comment 8 Bastien Nocera 2018-02-27 13:00:10 UTC 
I added a guard around the gdkwayland include. I also removed the i18n in the last version. It's not going to be used, so no need to bother translators.
Comment 9 Bastien Nocera 2018-02-27 13:01:24 UTC 
Attachment 368807 [details] pushed as 4b94e2c - idle-monitor: Remove per-device monitor from tests
Attachment 369017 [details] pushed as d4842ab - idle-monitor: Per-device idle monitors aren't supported in Wayland