After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793730 - missing files in `make dist` tarball
missing files in `make dist` tarball
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.27.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2018-02-22 19:07 UTC by Simon McVittie
Modified: 2018-02-23 21:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[1/4] lib: Ship the template files for maps-enum-types.[ch] (860 bytes, patch)
2018-02-22 19:08 UTC, Simon McVittie 		committed Details | Review
[2/4] lib: Don't include generated files in tarball releases (793 bytes, patch)
2018-02-22 19:09 UTC, Simon McVittie 		committed Details | Review
[3/4] data: Distribute source files for icons in dist tarball (852 bytes, patch)
2018-02-22 19:09 UTC, Simon McVittie 		committed Details | Review
[4/4] src: Distribute third-party license files (717 bytes, patch)
2018-02-22 19:09 UTC, Simon McVittie 		committed Details | Review

Description Simon McVittie 2018-02-22 19:07:49 UTC 
lib/maps-enum-types.?.template are missing from the distributed tarball. This is masked by the fact that the generated files lib/maps-enum-types.? are (incorrectly) present. However, this call sequence will fail:

./configure
make
make distclean
./configure
make

While fixing this I noticed that some other files were missing from dist tarballs, notably a couple of third-party licenses.
Comment 1 Simon McVittie 2018-02-22 19:08:56 UTC 
Created attachment 368790 [details] [review]
[1/4] lib: Ship the template files for maps-enum-types.[ch]

Otherwise it's impossible to build from a tarball after `make distclean`.

Bug-Debian: https://bugs.debian.org/891133
Comment 2 Simon McVittie 2018-02-22 19:09:16 UTC 
Created attachment 368791 [details] [review]
[2/4] lib: Don't include generated files in tarball releases
Comment 3 Simon McVittie 2018-02-22 19:09:36 UTC 
Created attachment 368792 [details] [review]
[3/4] data: Distribute source files for icons in dist tarball
Comment 4 Simon McVittie 2018-02-22 19:09:54 UTC 
Created attachment 368793 [details] [review]
[4/4] src: Distribute third-party license files
Comment 5 Marcus Lundblad 2018-02-23 14:24:47 UTC 
Thanks for the patches, will look at it when I get time!
Comment 6 Marcus Lundblad 2018-02-23 21:24:35 UTC 
Review of attachment 368790 [details] [review]:

LGTM
Comment 7 Marcus Lundblad 2018-02-23 21:24:53 UTC 
Review of attachment 368791 [details] [review]:

LGTM
Comment 8 Marcus Lundblad 2018-02-23 21:25:07 UTC 
Review of attachment 368792 [details] [review]:

LGTM
Comment 9 Marcus Lundblad 2018-02-23 21:25:08 UTC 
Review of attachment 368792 [details] [review]:

LGTM
Comment 10 Marcus Lundblad 2018-02-23 21:26:59 UTC 
Review of attachment 368791 [details] [review]:

LGTM
Comment 11 Marcus Lundblad 2018-02-23 21:27:16 UTC 
Review of attachment 368793 [details] [review]:

LGTM
Comment 12 Marcus Lundblad 2018-02-23 21:27:26 UTC 
Review of attachment 368790 [details] [review]:

LGTM