After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793717 - webrtcbin-test: rename of misleading variable name
webrtcbin-test: rename of misleading variable name
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-22 11:21 UTC by Andreas Frisch
Modified: 2018-11-03 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Rename misleading variable in webrtcbin test (2.77 KB, patch)
2018-02-22 11:21 UTC, Andreas Frisch 		needs-work Details | Review

Description Andreas Frisch 2018-02-22 11:21:06 UTC 
Created attachment 368748 [details] [review]
tests: Rename misleading variable in webrtcbin test

just a trivial rename "offerror" discriminator variables to "offerer" to prevent mistaking them for something to do with "error"
Comment 1 Nicolas Dufresne (ndufresne) 2018-02-22 15:49:41 UTC 
Review of attachment 368748 [details] [review]:

::: tests/check/elements/webrtcbin.c
@@ +108,3 @@
 {
   struct test_webrtc *t = user_data;
+  GstElement *offeror = t->offerer == 1 ? t->webrtc1 : t->webrtc2;

Shouldn't you rename the element pointer here ? Also, the the guint, I think we should try and find a two word name that means something.
Comment 2 GStreamer system administrator 2018-11-03 14:18:45 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/662.