After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793716 - WebKitWebView search: occurrences not highlighted in new tab
WebKitWebView search: occurrences not highlighted in new tab
Status: RESOLVED NOTGNOME
Product: devhelp
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2018-02-22 11:00 UTC by Sébastien Wilmet
Modified: 2018-07-28 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sébastien Wilmet 2018-02-22 11:00:54 UTC
Note that it is for the search in the HTML pages (in the WebKitWebView widget), *not* the search in the side panel.

Steps to reproduce:
1. Launch Devhelp.
2. Open a page, for example "GLib Reference Manual".
3. Ctrl+F and search "a" -> the occurrences are correctly highlighted.
4. Do not close the search, and open a new tab (initially blank page).
5. In the new tab, open a page, for example "GIO Reference Manual".
--> In the new tab the search occurrences are not highlighted. Clicking on the next/previous search buttons works, but the occurrences are still not highlighted after clicking on those buttons.

I don't know if it's a WebKitGTK+ bug, or if there is some missing code in Devhelp (for example calling webkit_find_controller_search() in WebKitWebView::load-changed). We can see if Epiphany has the same bug, and if it doesn't have the bug, look at its implementation.
Comment 1 Sébastien Wilmet 2018-05-19 13:04:54 UTC
There is another way to reproduce the bug:
1. Launch Devhelp.
2. Open a page, for example "GLib Reference Manual".
3. Ctrl+F and search "a" -> the occurrences are correctly highlighted.
4. In the same tab, open another page by clicking on a link.
--> in the new page content the search occurrences are no longer highlighted.

Epiphany is good at avoiding this bug:
- It has a different GtkSearchBar for each tab, while Devhelp re-uses the same GtkSearchBar for all the tabs. In Epiphany when creating a new tab its GtkSearchBar is initially hidden.
- If the GtkSearchBar of a tab is shown, when opening another page in the same tab the GtkSearchBar is hidden.
Comment 2 Sébastien Wilmet 2018-05-19 13:29:30 UTC
I've filed this WebKitGTK+ bug:
https://bugs.webkit.org/show_bug.cgi?id=185798
Comment 3 Sébastien Wilmet 2018-07-28 15:06:20 UTC
I suppose it's a WebKitGTK+ bug, so I close this one.