After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793694 - gst-omx: add support for NV16_10LE32 and NV12_10LE32 formats
gst-omx: add support for NV16_10LE32 and NV12_10LE32 formats
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-21 14:01 UTC by Guillaume Desmottes
Modified: 2018-02-28 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
omxvideoenc: display the computed buffer size when configuring input (1.59 KB, patch)
2018-02-21 14:01 UTC, Guillaume Desmottes
committed Details | Review
omxvideoenc: factor out gst_omx_video_enc_nv12_manual_copy() (5.09 KB, patch)
2018-02-21 14:01 UTC, Guillaume Desmottes
committed Details | Review
add support for NV12_10LE32 and NV16_10LE32 on zynqultrascaleplus (9.45 KB, patch)
2018-02-21 14:01 UTC, Guillaume Desmottes
committed Details | Review
videoenc: don't set stride padding to 0 when copying frames (3.09 KB, patch)
2018-02-21 14:01 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2018-02-21 14:01:08 UTC
See https://bugzilla.gnome.org/show_bug.cgi?id=789876 about those formats.
Comment 1 Guillaume Desmottes 2018-02-21 14:01:25 UTC
Created attachment 368713 [details] [review]
omxvideoenc: display the computed buffer size when configuring input
Comment 2 Guillaume Desmottes 2018-02-21 14:01:29 UTC
Created attachment 368714 [details] [review]
omxvideoenc: factor out gst_omx_video_enc_nv12_manual_copy()

No semantic change, I'm going to re-use it to copy the NV12_10LE32
format.
Comment 3 Guillaume Desmottes 2018-02-21 14:01:35 UTC
Created attachment 368715 [details] [review]
add support for NV12_10LE32 and NV16_10LE32 on zynqultrascaleplus

The encoder and decoder on zynqultrascaleplus support these new 10 bits
format.
Comment 4 Guillaume Desmottes 2018-02-21 14:01:39 UTC
Created attachment 368716 [details] [review]
videoenc: don't set stride padding to 0 when copying frames

Padding can be left undefined there is no point filling it with 0.
Comment 5 Nicolas Dufresne (ndufresne) 2018-02-28 13:32:41 UTC
Attachment 368713 [details] pushed as f257051 - omxvideoenc: display the computed buffer size when configuring input
Attachment 368714 [details] pushed as d1ffc97 - omxvideoenc: factor out gst_omx_video_enc_nv12_manual_copy()
Attachment 368715 [details] pushed as ea2df99 - add support for NV12_10LE32 and NV16_10LE32 on zynqultrascaleplus
Attachment 368716 [details] pushed as f861ad2 - videoenc: don't set stride padding to 0 when copying frames