After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793675 - Can't call g_error_free() in VteTerminalSpawnAsyncCallback
Can't call g_error_free() in VteTerminalSpawnAsyncCallback
Status: RESOLVED OBSOLETE
Product: vte
Classification: Core
Component: general
0.50.x
Other Linux
: Normal enhancement
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks: vte1.0
 
 
Reported: 2018-02-20 19:38 UTC by Tony Houghton
Modified: 2021-06-10 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tony Houghton 2018-02-20 19:38:10 UTC 
If an error is passed to the VteTerminalSpawnAsyncCallback after calling vte_terminal_spawn_async(), attempting to free that error causes a double-free. VteTerminalSpawnAsyncCallback's signature should be changed so that error is const, or at least documented to make sure the callee knows not to try to free this error.
Comment 1 Christian Persch 2018-02-20 20:49:17 UTC 
(In reply to Tony Houghton from comment #0)
> VteTerminalSpawnAsyncCallback's signature should be changed so
> that error is const,

Yes, this.
Comment 2 Christian Persch 2018-02-20 20:50:48 UTC 
However that would be an API change, so needs to wait for the nxt break.

In the meanwhile, documenting is good.
Comment 3 GNOME Infrastructure Team 2021-06-10 15:29:51 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vte/-/issues/2480.