After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793646 - GIMP crashes when trying to edit metadata
GIMP crashes when trying to edit metadata
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: Plugins
2.9.8
Other Windows
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2018-02-20 12:31 UTC by OldNick
Modified: 2018-05-24 19:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
picture of a dog (312.84 KB, image/jpeg)
2018-02-20 17:07 UTC, OldNick
Details

Description OldNick 2018-02-20 12:31:50 UTC
Win 7 Home Prem 64 bit. Simply tried to edit metadata of a jpg. 100% repeatable.

Problem signature:
  Problem Event Name:	APPCRASH
  Application Name:	metadata-editor.exe
  Application Version:	2.9.8.0
  Application Timestamp:	5a32a936
  Fault Module Name:	msvcrt.dll
  Fault Module Version:	7.0.7600.16385
  Fault Module Timestamp:	4a5bdfbe
  Exception Code:	c0000005
  Exception Offset:	000000000001427c
  OS Version:	6.1.7601.2.1.0.768.3
  Locale ID:	3081
  Additional Information 1:	7ee5
  Additional Information 2:	7ee5370db876410d25fc33413bd1644e
  Additional Information 3:	bbe3
  Additional Information 4:	bbe348e3facfead5b1d34f66add4bc03

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement offline:
  C:\Windows\system32\en-US\erofflps.txt
Comment 1 Michael Natterer 2018-02-20 13:02:46 UTC
Thanks. Can you please attach one of the affected files to
this bug report?
Comment 2 OldNick 2018-02-20 17:07:53 UTC
Created attachment 368664 [details]
picture of a dog

I realised the bug actually only crashes the plugin:

Plug-in crashed: "metadata-editor.exe"
(C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\metadata-editor.exe)

The dying plug-in may have messed up GIMP's internal state. You may want to save your images and restart GIMP to be on the safe side.
Comment 3 Jehan 2018-02-21 23:29:23 UTC
OldNick > I could not reproduce with your image. What are you doing exactly when it crashes? Are you simply opening the "Edit Metadata" dialog and it directly crashes? Could you give us exact reproduction steps? Thanks.
Comment 4 OldNick 2018-02-22 03:34:58 UTC
I:
(1) Open Gimp 2.9
(2) Load an image any image: jpg
(3) Choose Image/ metadata / Edit Metadata

A Dbox comes up

GNU Image Manipulation Program Plug-In has stopped working
Windows can check online for a solution to the problem
-> Check online for the solution amd close the program
-> Close the program

View problem details.
Problem signature:
  Problem Event Name:	APPCRASH
  Application Name:	metadata-editor.exe
  Application Version:	2.9.8.0
  Application Timestamp:	5a32a936
  Fault Module Name:	msvcrt.dll
  Fault Module Version:	7.0.7600.16385
  Fault Module Timestamp:	4a5bdfbe
  Exception Code:	c0000005
  Exception Offset:	000000000001427c
  OS Version:	6.1.7601.2.1.0.768.3
  Locale ID:	3081
  Additional Information 1:	7ee5
  Additional Information 2:	7ee5370db876410d25fc33413bd1644e
  Additional Information 3:	bbe3
  Additional Information 4:	bbe348e3facfead5b1d34f66add4bc03

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement offline:
  C:\Windows\system32\en-US\erofflps.txt
Comment 5 Rob Townley 2018-03-01 19:18:17 UTC
metadata-editor.exe crashes immediately whether using a brand new image based on a default GIMP template
or an existing image.  I also tried deleting the duplicated section of 
'C:\Program Files\GIMP 2.9\share\gimp\2.0\menus\image-menu.xml',
but same crash.  

OS=Win10 1709 OS Build 16299.248
GNU Image Manipulation Program version 2.9.8

#I launched from an elevated PowerShell.exe console using --no-shm.  
.\gimp-2.9.exe --verbose --no-shm --console-messages

#Copied from the console:

Starting extension: 'extension-script-fu'
INIT: gui_restore_after_callback
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\menurc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\action-history'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\devicerc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\controllerrc'
loading menu 'C:\Program Files\GIMP 2.9\share\gimp\2.0\menus\image-menu.xml' for /image-menubar

(gimp-2.9.exe:27744): LibGimpBase-WARNING **: gimp-2.9.exe: gimp_wire_read(): error
GIMP-Error: Plug-in crashed: "metadata-editor.exe"
(C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\metadata-editor.exe)

The dying plug-in may have messed up GIMP's internal state. You may want to save your images and restart GIMP to be on the safe side.

*WARNING* missing babl fast path(s): "RGBA float" to "R'G'B' u8"

(gimp-2.9.exe:27744): LibGimpBase-WARNING **: gimp-2.9.exe: gimp_wire_read(): error
GIMP-Error: Plug-in crashed: "metadata-editor.exe"
(C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\metadata-editor.exe)

The dying plug-in may have messed up GIMP's internal state. You may want to save your images and restart GIMP to be on the safe side.


(gimp-2.9.exe:27744): LibGimpBase-WARNING **: gimp-2.9.exe: gimp_wire_read(): error
GIMP-Error: Plug-in crashed: "metadata-editor.exe"
(C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\metadata-editor.exe)

The dying plug-in may have messed up GIMP's internal state. You may want to save your images and restart GIMP to be on the safe side.

EXIT: gimp_exit
EXIT: gui_exit_callback
EXIT: gimp_exit
EXIT: gui_exit_callback



#With modified 'C:\Program Files\GIMP 2.9\share\gimp\2.0\menus\image-menu.xml' 
#Using a built in GIMP template to define the image.

Parsing 'C:\Program Files\GIMP 2.9\etc\gimp\2.0\gimprc' for configured language.
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\gimprc' for configured language.
No language property found.
This is a development version of GIMP.  Debug messages may appear here.

INIT: gimp_load_config
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\unitrc'
Parsing 'C:\Program Files\GIMP 2.9\etc\gimp\2.0\gimprc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\gimprc'
Adding icon theme 'Color' (C:\Program Files\GIMP 2.9\share\gimp\2.0\icons\Color)
Adding icon theme 'Legacy' (C:\Program Files\GIMP 2.9\share\gimp\2.0\icons\Legacy)
Adding icon theme 'Symbolic' (C:\Program Files\GIMP 2.9\share\gimp\2.0\icons\Symbolic)
Adding icon theme 'Symbolic-Inverted' (C:\Program Files\GIMP 2.9\share\gimp\2.0\icons\Symbolic-Inverted)
Loading icon theme 'Symbolic'
Missing fast-path babl conversion detected, Implementing missing babl fast paths
accelerates GEGL, GIMP and other software using babl, warnings are printed on
first occurance of formats used where a conversion has to be synthesized
programmatically by babl based on format description

*WARNING* missing babl fast path(s): "CIE LCH(ab) double" to "R'G'B' double"
Adding theme '00-Lighter' (C:\Program Files\GIMP 2.9\share\gimp\2.0\themes\00-Lighter)
Adding theme '01-Light' (C:\Program Files\GIMP 2.9\share\gimp\2.0\themes\01-Light)
Adding theme '02-Gray' (C:\Program Files\GIMP 2.9\share\gimp\2.0\themes\02-Gray)
Adding theme '03-Dark' (C:\Program Files\GIMP 2.9\share\gimp\2.0\themes\03-Dark)
Adding theme '04-Darker' (C:\Program Files\GIMP 2.9\share\gimp\2.0\themes\04-Darker)
Adding theme 'System' (C:\Program Files\GIMP 2.9\share\gimp\2.0\themes\System)
Writing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\themerc'
Trying splash 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\gimp-splash.png' ... failed
Trying splash 'C:\Program Files\GIMP 2.9\share\gimp\2.0\images\gimp-splash.png' ... OK
INIT: gimp_initialize
INIT: gimp_real_initialize
Parsing 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\interpreters\default.interp'
Parsing 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\interpreters\pygimp.interp'
Parsing 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\environ\default.env'
Parsing 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\environ\pygimp.env'
INIT: gui_initialize_after_callback
INIT: gimp_restore
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\parasiterc'
Loading 'brush factory' data
Loading 'dynamics factory' data
Loading 'mypaint brush factory' data
Loading 'pattern factory' data
Loading 'palette factory' data
Loading 'gradient factory' data
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\colorrc'
Loading 'tool preset factory' data
Loading fonts
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\templaterc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\modulerc'
Loading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libcolor-selector-cmyk.dll'
Unloading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libcolor-selector-cmyk.dll'
Loading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libcolor-selector-water.dll'
Unloading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libcolor-selector-water.dll'
Loading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libcolor-selector-wheel.dll'
Unloading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libcolor-selector-wheel.dll'
Loading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libcontroller-dx-dinput.dll'
Unloading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libcontroller-dx-dinput.dll'
Loading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libdisplay-filter-clip-warning.dll'
Unloading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libdisplay-filter-clip-warning.dll'
Loading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libdisplay-filter-color-blind.dll'
Unloading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libdisplay-filter-color-blind.dll'
Loading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libdisplay-filter-gamma.dll'
Unloading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libdisplay-filter-gamma.dll'
Loading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libdisplay-filter-high-contrast.dll'
Unloading module 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\modules\libdisplay-filter-high-contrast.dll'
INIT: gui_restore_callback
clipboard: writable pixbuf format: image/png
clipboard: writable pixbuf format: image/bmp
clipboard: writable pixbuf format: image/x-bmp
clipboard: writable pixbuf format: image/x-MS-bmp
clipboard: writable pixbuf format: image/tiff
clipboard: writable pixbuf format: image/gif
clipboard: writable pixbuf format: image/jpeg
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\sessionrc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\dockrc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\toolrc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\contextrc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\internal-data\custom.ggr'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-rect-select-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-ellipse-select-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-free-select-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-fuzzy-select-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-by-color-select-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-iscissors-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-foreground-select-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-vector-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-color-picker-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-zoom-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-measure-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-move-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-align-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-crop-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-unified-transform-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-rotate-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-scale-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-shear-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-handle-transform-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-perspective-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-flip-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-cage-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-warp-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-text-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-bucket-fill-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-blend-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-pencil-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-paintbrush-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-eraser-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-airbrush-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-ink-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-mypaint-brush-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-clone-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-heal-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-perspective-clone-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-convolve-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-smudge-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-dodge-burn-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-brightness-contrast-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-threshold-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-levels-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-curves-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-gegl-tool'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\tool-options\gimp-operation-tool'
INIT: gimp_real_restore
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\pluginrc'
Querying plug-in: 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\file-rawtherapee.exe'
Querying plug-in: 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\file-darktable.exe'
Initializing plug-in: 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\file-rawtherapee.exe'
Initializing plug-in: 'C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\file-darktable.exe'
Writing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\pluginrc'
Starting extension: 'extension-script-fu'
INIT: gui_restore_after_callback
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\menurc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\action-history'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\devicerc'
Parsing 'C:\Users\ElevatedAdminUser\AppData\Roaming\GIMP\2.9\controllerrc'
loading menu 'C:\Program Files\GIMP 2.9\share\gimp\2.0\menus\image-menu.xml' for /image-menubar

(gimp-2.9.exe:31552): LibGimpBase-WARNING **: gimp-2.9.exe: gimp_wire_read(): error
GIMP-Error: Plug-in crashed: "metadata-editor.exe"
(C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\metadata-editor.exe)

The dying plug-in may have messed up GIMP's internal state. You may want to save your images and restart GIMP to be on the safe side.

EXIT: gimp_exit
EXIT: gui_exit_callback
Comment 6 Rob Townley 2018-03-01 19:21:31 UTC

loading menu 'C:\Program Files\GIMP 2.9\share\gimp\2.0\menus\image-menu.xml' for /image-menubar

(gimp-2.9.exe:31552): LibGimpBase-WARNING **: gimp-2.9.exe: gimp_wire_read(): error
GIMP-Error: Plug-in crashed: "metadata-editor.exe"
(C:\Program Files\GIMP 2.9\lib\gimp\2.0\plug-ins\metadata-editor.exe)
Comment 7 OldNick 2018-03-16 13:04:31 UTC
 Michael Schumacher changed bug 793646
What 	****Removed**** 	Added
Status 	NEEDINFO 	UNCONFIRMED
Ever confirmed 	1 	 

You are receiving this mail because:

    You are on the CC list for the bug.
    You reported the bug.


Huh?. I have tried to provide whatever you ask. Two other guys have seen the same bug.

REMOVED? NEEDINFO? 

You want to fix this or not?
Comment 8 Jehan 2018-03-16 13:23:01 UTC
Hello OldNick,

Do not mind too much the status. NEEDINFO meant we were asking things from you, and you answered, which is why he removed the NEEDINFO, that's all (and that's a good step towards resolution). As for UNCONFIRMED, this is mostly because even though the info you provided is very verbose, it is unfortunately not that useful (which is not your fault, the terminal logs you provided just don't have much of the relevant data), and we could not reproduce.

It does not mean we do not want to fix or anything like that. Statuses for bug reports are a bit stiff, so don't take them personally.

In any case, the edit metadata plug-in has much deeper problems. Its code is very bugged and unstable (even though I could not reproduce your direct crash with the attached image, I have a lot of warning messages when using it). It definitely needs a big rework/cleaning. But none of us can make the time for it right now.

On the other hand, we are really welcoming patches. If anyone wants to contribute to improve the situation, we would be very grateful.

Anyway setting to NEW.

I guess we could use this bug report for follow-up of the plug-in cleaning to a sane state. I am guessing that some of the WARNING/CRITICAL we get on Linux result in crashes instead on Windows (there are so many warnings in this plug-in, this is insane). Probably just cleaning this code may fix your crash.
Comment 9 Jehan 2018-03-16 19:32:37 UTC
Some first code cleaning which was giving me a lot of warning when quitting the metadata editor.

commit 4fdf301dea96f607aba3d4c1a5ab6e5e4232f3c3 (HEAD -> master, origin/master, origin/HEAD)
Author: Jehan <jehan@girinstud.io>
Date:   Fri Mar 16 20:20:24 2018 +0100

    plug-ins: properly check widget class holding tag data.
    
    Some tag data is hold in GtkEntry, other in GtkTextView, which are not
    parent to each other. Previous checks were wrong and resulted in
    "invalid cast from 'GtkEntry' to 'GtkTextView'" WARNINGs (followed by
    many CRITICALs because of this first error).
    
    Also properly free the data returned by gtk_text_buffer_get_text() which
    is allocated (unlike strings returned by gtk_entry_get_text() which must
    not be freed).

 plug-ins/metadata/metadata-editor.c | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)
Comment 10 OldNick 2018-03-17 11:57:04 UTC
Thank you for your concern, seriously. I thought the BUG had been removed. Sorry bout that.

Nick

(In reply to Jehan from comment #8)
> Hello OldNick,
> 
> Do not mind too much the status. NEEDINFO meant we were asking things from
> you, and you answered, which is why he removed the NEEDINFO, that's all (and
> that's a good step towards resolution). As for UNCONFIRMED, this is mostly
> because even though the info you provided is very verbose, it is
> unfortunately not that useful (which is not your fault, the terminal logs
> you provided just don't have much of the relevant data), and we could not
> reproduce.
> 
> It does not mean we do not want to fix or anything like that. Statuses for
> bug reports are a bit stiff, so don't take them personally.
> 
> In any case, the edit metadata plug-in has much deeper problems. Its code is
> very bugged and unstable (even though I could not reproduce your direct
> crash with the attached image, I have a lot of warning messages when using
> it). It definitely needs a big rework/cleaning. But none of us can make the
> time for it right now.
> 
> On the other hand, we are really welcoming patches. If anyone wants to
> contribute to improve the situation, we would be very grateful.
> 
> Anyway setting to NEW.
> 
> I guess we could use this bug report for follow-up of the plug-in cleaning
> to a sane state. I am guessing that some of the WARNING/CRITICAL we get on
> Linux result in crashes instead on Windows (there are so many warnings in
> this plug-in, this is insane). Probably just cleaning this code may fix your
> crash.
Comment 11 OldNick 2018-03-17 11:58:06 UTC
Sorry, bug _report_ had been removed.
Comment 12 Jehan 2018-03-17 12:22:56 UTC
(In reply to OldNick from comment #10)
> Thank you for your concern, seriously. I thought the BUG had been removed.
> Sorry bout that.

No prob. What was *removed* was the status which had been replaced by another. :-) The email notification may indeed not be that clear.

In any case, since your plug-in crash happens immediately when starting the plug-in, I doubt this is related to what I fixed in comment 9, but I still can't reproduce. It is probably a Windows-only issue, which makes it harder because we have very few Windows contributors.

We'll leave it opened for now. I'll add the "newcomers" keyword as a wishful thought that a plug-in crash should not be hard to fix (if one can reproduce it), so it may bring more Windows developer eyes to look into it.
Comment 13 Massimo 2018-03-17 13:06:28 UTC
(In reply to Jehan from comment #12)
> (In reply to OldNick from comment #10)
> > Thank you for your concern, seriously. I thought the BUG had been removed.
> > Sorry bout that.
> 
> No prob. What was *removed* was the status which had been replaced by
> another. :-) The email notification may indeed not be that clear.
> 
> In any case, since your plug-in crash happens immediately when starting the
> plug-in, I doubt this is related to what I fixed in comment 9, but I still
> can't reproduce. It is probably a Windows-only issue, which makes it harder
> because we have very few Windows contributors.
> 
> We'll leave it opened for now. I'll add the "newcomers" keyword as a wishful
> thought that a plug-in crash should not be hard to fix (if one can reproduce
> it), so it may bring more Windows developer eyes to look into it.

It could have been fixed in January, after gimp-2.9.8 release,
by this commit:

https://git.gnome.org/browse/gimp/commit/plug-ins/metadata?id=62ee5d3c7ed79886fcac71ca93ab7206c170417e

So it would be interesting to know whether a later Windows GIMP 
build still crahes
Comment 14 Jehan 2018-03-17 13:29:06 UTC
Oh right, I don't know why, in my (crazy) mind, the reporter was using the master version. But you are right. Since he is using released 2.9.8, maybe the crash is already fixed!

Nick > I guess you'll have to test again when we make a new development release! :-)
Comment 15 GNOME Infrastructure Team 2018-05-24 19:10:20 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/1309.