After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793637 - omxbufferpool: add DEBUG message when copying output frames
omxbufferpool: add DEBUG message when copying output frames
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-20 10:59 UTC by Guillaume Desmottes
Modified: 2018-02-21 11:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
omxbufferpool: add DEBUG message when copying output frames (1.39 KB, patch)
2018-02-20 11:00 UTC, Guillaume Desmottes
none Details | Review
omxbufferpool: add DEBUG message when copying output frames (1.71 KB, patch)
2018-02-21 09:35 UTC, Guillaume Desmottes
reviewed Details | Review
omxbufferpool: add PERFORMANCE DEBUG message when copying output frames (2.11 KB, patch)
2018-02-21 10:43 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2018-02-20 10:59:47 UTC
.
Comment 1 Guillaume Desmottes 2018-02-20 11:00:03 UTC
Created attachment 368623 [details] [review]
omxbufferpool: add DEBUG message when copying output frames

I spent quiet some time figuring out why performance of my pipeline were
terrible. Turned out it was because of output frames being copied
because of stride/offset mismatch.

Add a DEBUG message to make it easier to spot and debug from logs.
Comment 2 Nicolas Dufresne (ndufresne) 2018-02-20 15:46:35 UTC
Review of attachment 368623 [details] [review]:

Should it be using PERFORMANCE category?
Comment 3 Guillaume Desmottes 2018-02-21 09:03:51 UTC
Don't know. Isn't PERFORMANCE mostly used for high traffic log messages so they can easily be filtered out/in? Those will only be displayed once per buffer when allocating so I'd say to keep it in the omx pool category.
Comment 4 Tim-Philipp Müller 2018-02-21 09:27:25 UTC
"High traffic" messages will usually be filtered in/out via the log level (LOG, TRACE).

The PERFORMANCE category is used for messages that affect performance, usually negatively.
Comment 5 Guillaume Desmottes 2018-02-21 09:35:17 UTC
Created attachment 368694 [details] [review]
omxbufferpool: add DEBUG message when copying output frames

I spent quiet some time figuring out why performance of my pipeline were
terrible. Turned out it was because of output frames being copied
because of stride/offset mismatch.

Add a DEBUG message to make it easier to spot and debug from logs.
Comment 6 Guillaume Desmottes 2018-02-21 09:45:12 UTC
Thanks for the clarification, I updated the patch.
Comment 7 Tim-Philipp Müller 2018-02-21 09:48:57 UTC
Comment on attachment 368694 [details] [review]
omxbufferpool: add DEBUG message when copying output frames

I think you need to retrieve GST_CAT_PERFORMANCE here, because it's not exported as a symbol and you made it STATIC.

Also the commit message should be updated.
Comment 8 Guillaume Desmottes 2018-02-21 10:43:45 UTC
Created attachment 368700 [details] [review]
omxbufferpool: add PERFORMANCE DEBUG message when copying output frames

I spent quiet some time figuring out why performance of my pipeline were
terrible. Turned out it was because of output frames being copied
because of stride/offset mismatch.

Add a PERFORMANCE DEBUG message to make it easier to spot and debug from logs.
Comment 9 Tim-Philipp Müller 2018-02-21 11:32:05 UTC
Thanks!

commit 412df8c74f29992ff93ab88f6d7b7625ebcc8193
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Tue Feb 20 11:46:49 2018 +0100

    omxbufferpool: add PERFORMANCE DEBUG message when copying output frames
    
    I spent quiet some time figuring out why performance of my pipeline were
    terrible. Turned out it was because of output frames being copied
    because of stride/offset mismatch.
    
    Add a PERFORMANCE DEBUG message to make it easier to spot and debug from logs.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=793637