GNOME Bugzilla – Bug 793637
omxbufferpool: add DEBUG message when copying output frames
Last modified: 2018-02-21 11:32:38 UTC
.
Created attachment 368623 [details] [review] omxbufferpool: add DEBUG message when copying output frames I spent quiet some time figuring out why performance of my pipeline were terrible. Turned out it was because of output frames being copied because of stride/offset mismatch. Add a DEBUG message to make it easier to spot and debug from logs.
Review of attachment 368623 [details] [review]: Should it be using PERFORMANCE category?
Don't know. Isn't PERFORMANCE mostly used for high traffic log messages so they can easily be filtered out/in? Those will only be displayed once per buffer when allocating so I'd say to keep it in the omx pool category.
"High traffic" messages will usually be filtered in/out via the log level (LOG, TRACE). The PERFORMANCE category is used for messages that affect performance, usually negatively.
Created attachment 368694 [details] [review] omxbufferpool: add DEBUG message when copying output frames I spent quiet some time figuring out why performance of my pipeline were terrible. Turned out it was because of output frames being copied because of stride/offset mismatch. Add a DEBUG message to make it easier to spot and debug from logs.
Thanks for the clarification, I updated the patch.
Comment on attachment 368694 [details] [review] omxbufferpool: add DEBUG message when copying output frames I think you need to retrieve GST_CAT_PERFORMANCE here, because it's not exported as a symbol and you made it STATIC. Also the commit message should be updated.
Created attachment 368700 [details] [review] omxbufferpool: add PERFORMANCE DEBUG message when copying output frames I spent quiet some time figuring out why performance of my pipeline were terrible. Turned out it was because of output frames being copied because of stride/offset mismatch. Add a PERFORMANCE DEBUG message to make it easier to spot and debug from logs.
Thanks! commit 412df8c74f29992ff93ab88f6d7b7625ebcc8193 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Tue Feb 20 11:46:49 2018 +0100 omxbufferpool: add PERFORMANCE DEBUG message when copying output frames I spent quiet some time figuring out why performance of my pipeline were terrible. Turned out it was because of output frames being copied because of stride/offset mismatch. Add a PERFORMANCE DEBUG message to make it easier to spot and debug from logs. https://bugzilla.gnome.org/show_bug.cgi?id=793637