After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793625 - [PATCH] Do not return without mutex unlock
[PATCH] Do not return without mutex unlock
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-02-20 03:43 UTC by kimcinoo.efl
Modified: 2018-03-05 23:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch concerning mutex usage (1.52 KB, patch)
2018-02-20 03:43 UTC, kimcinoo.efl
committed Details | Review

Description kimcinoo.efl 2018-02-20 03:43:38 UTC
Created attachment 368593 [details] [review]
patch concerning mutex usage

Dear All, Hello.

Please find attached patch.
The commit message is explaining what, and why as below :-]
                           
                                                                                
Subject: [PATCH] Do not return without mutex unlock                             
                                                                                
It is not possible to use cache,                                                
after child_added_listener(or toplevel_added_listener) returns by calling       
g_return_val_if_fail, without g_rec_mutex_unlock.   


Sincerely,
Shinwoo Kim.
Comment 1 Mike Gorse 2018-03-05 23:50:18 UTC
Lgtm. Thanks for the patch.
Pushed to master: 493b5a
Pushed to gnome-3-26: 0ffcb8