GNOME Bugzilla – Bug 793613
NTLMv2 responses support
Last modified: 2018-09-21 16:34:24 UTC
Created attachment 368585 [details] [review] Diff file with modifications for soup-auth-ntlm.c. Hello, since we set in our AD domain domain-wide policy settings "Send NTLMv2 response only. Refuse LM & NTLM", NTLM auth stopped working for me in Evolution. Evolution uses libsoup to connect to the Exchange Web Service. So I tried to make an implementation of NTLMv2 responses for libsoup. Diff file for soup-auth-ntlm.c file is attached. With this patch, NTLM auth works for me. But it was not tested by anyone else yet. I also don't know, if it didn't break something else. And at last, I am no programmer, this is my first C code ever, so I imagine it might need to be "beautified". If someone could take a look at it, that would be great. Thanks & Regards Michal Hrubý
David, can you please review this patch?
Seems reasonable in concept. There are a lot of magic numbers which make me a little unhappy; I'd like to see it tidied up a bit. The only real problem I see is the UTF-8 to UTF-16 conversion which only works for characters < 128: + while (*user_domain) + { + *p++ = *user_domain++; + *p++ = '\0'; + }
Created attachment 371904 [details] [review] Updated diff file with modifications for soup-auth-ntlm.c.
Hello, thanks David for the review. I've uploaded an updated version, which I am using right now. Regards Michal Hrubý
Hello, is this still active or everything had moved to GitLab? Should I make a merge request there? Thanks MH
It will be easier Michal if you could create the MR on GitLab. Thank you.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libsoup/issues/114.