After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793596 - Make microphone mute button configurable
Make microphone mute button configurable
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 793641
 
 
Reported: 2018-02-19 13:54 UTC by Benjamin Berg
Modified: 2018-03-20 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
media-keys: Remove legacy mapping from F20 to microphone mute (1.51 KB, patch)
2018-02-19 13:54 UTC, Benjamin Berg
none Details | Review
media-keys: Move microphone mute button to gsettings (2.38 KB, patch)
2018-02-19 13:55 UTC, Benjamin Berg
none Details | Review
media-keys: Move microphone mute button to gsettings (2.35 KB, patch)
2018-02-19 13:59 UTC, Benjamin Berg
none Details | Review
keyboard: Add microphone mute key (1.56 KB, patch)
2018-02-19 14:33 UTC, Benjamin Berg
none Details | Review
media-keys: Clarify in settings that the mute key toggles the state (1.22 KB, patch)
2018-02-20 11:54 UTC, Benjamin Berg
none Details | Review
media-keys: Remove legacy mapping from F20 to microphone mute (1.51 KB, patch)
2018-02-20 11:54 UTC, Benjamin Berg
none Details | Review
media-keys: Move microphone mute button to gsettings (2.36 KB, patch)
2018-02-20 11:54 UTC, Benjamin Berg
none Details | Review

Description Benjamin Berg 2018-02-19 13:54:55 UTC
This is useful on machines that do not have a hardware mute key.
Comment 1 Benjamin Berg 2018-02-19 13:54:58 UTC
Created attachment 368559 [details] [review]
media-keys: Remove legacy mapping from F20 to microphone mute

The current situation is that udev maps the microphone key to F20, which
is then mapped to XF86AudioMicMute by the X keyboard config. The
requirement to explicitly handle F20 is therefore gone since the
libxkbcommon has been merged mid 2013.

See also https://bugs.freedesktop.org/show_bug.cgi?id=54171
Comment 2 Benjamin Berg 2018-02-19 13:55:02 UTC
Created attachment 368560 [details] [review]
media-keys: Move microphone mute button to gsettings

Allow users to configure the microphone mute key. Many laptops do not
have a microphone mute key, so it can make sense for users to map it to
another key (e.g. Shift+Mute).
Comment 3 Benjamin Berg 2018-02-19 13:59:15 UTC
Created attachment 368561 [details] [review]
media-keys: Move microphone mute button to gsettings

Allow users to configure the microphone mute key. Many laptops do not
have a microphone mute key, so it can make sense for users to map it to
another key (e.g. Shift+Mute).
Comment 4 Benjamin Berg 2018-02-19 14:33:54 UTC
Created attachment 368564 [details] [review]
keyboard: Add microphone mute key
Comment 5 Benjamin Berg 2018-02-20 11:54:35 UTC
Created attachment 368627 [details] [review]
media-keys: Clarify in settings that the mute key toggles the state

Just a simple string change to clarify that the key toggles the state.
Comment 6 Benjamin Berg 2018-02-20 11:54:40 UTC
Created attachment 368628 [details] [review]
media-keys: Remove legacy mapping from F20 to microphone mute

The current situation is that udev maps the microphone key to F20, which
is then mapped to XF86AudioMicMute by the X keyboard config. The
requirement to explicitly handle F20 is therefore gone since the
libxkbcommon has been merged mid 2013.

See also https://bugs.freedesktop.org/show_bug.cgi?id=54171
Comment 7 Benjamin Berg 2018-02-20 11:54:45 UTC
Created attachment 368629 [details] [review]
media-keys: Move microphone mute button to gsettings

Allow users to configure the microphone mute key. Many laptops do not
have a microphone mute key, so it can make sense for users to map it to
another key (e.g. Shift+Mute).
Comment 8 Peter Hutterer 2018-02-23 06:43:43 UTC
fwiw, this is a result of xkeyboard-config, not libxkbcommon. xk-c contains the mappings, libxkbcommon just makes them available. ACK from me
Comment 9 Benjamin Berg 2018-03-20 15:25:05 UTC
Pushed to master.