After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793588 - adding ScrollTo to at-spi-atk
adding ScrollTo to at-spi-atk
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on: 793587
Blocks:
 
 
Reported: 2018-02-19 09:19 UTC by Samuel Thibault
Modified: 2018-05-17 01:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed implementation (3.63 KB, text/plain)
2018-02-19 09:19 UTC, Samuel Thibault 		  Details
proposed implementation (3.89 KB, patch)
2018-05-02 09:45 UTC, Samuel Thibault 		none Details | Review
proposed implementation (3.92 KB, patch)
2018-05-02 13:28 UTC, Samuel Thibault 		none Details | Review

Description Samuel Thibault 2018-02-19 09:19:04 UTC 
Created attachment 368547 [details]
proposed implementation

Here is a proposed atk implementation for scrollto, as discussed in https://bugzilla.gnome.org/show_bug.cgi?id=792820
Comment 1 Mike Gorse 2018-03-30 09:37:11 UTC 
Thanks for the patch. I apologize for not replying sooner. Anyway, the patch looks good to me, assuming that the atk API changes are committed as you propose. I've dropped autoconf support post-2.26, and meson.build will need to be updated to depend on the correct version of atk, although I could fix this when I commit the patch.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-05-01 07:14:26 UTC 
What is the difference between this bug and bug 792820? Both have a really similar name.
Comment 3 Samuel Thibault 2018-05-01 07:16:44 UTC 
They are just the at-spi2-core vs at-spi2-atk patch submissions.
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-05-01 07:43:00 UTC 
(In reply to Samuel Thibault from comment #3)
> They are just the at-spi2-core vs at-spi2-atk patch submissions.

ok thanks. Tweaking the names to avoid confusion.
Comment 5 Samuel Thibault 2018-05-02 09:45:55 UTC 
Created attachment 371603 [details] [review]
proposed implementation

Here is a version with fixed version dependency.
Comment 6 Samuel Thibault 2018-05-02 13:28:19 UTC 
Created attachment 371615 [details] [review]
proposed implementation

Here it is rebased on latest git.
Comment 7 Mike Gorse 2018-05-17 01:51:28 UTC 
Pushed to master. Thanks for the work.