After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793581 - revision-walker: Take a reference on repository property
revision-walker: Take a reference on repository property
Status: RESOLVED FIXED
Product: libgit2-glib
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2018-02-19 00:58 UTC by Florian Müllner
Modified: 2019-02-22 03:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
revision-walker: Take a reference on repository property (1.02 KB, patch)
2018-02-19 00:59 UTC, Florian Müllner 		none Details | Review
revision-walker: Take a reference on repository property (1.90 KB, patch)
2018-02-19 15:38 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2018-02-19 00:58:56 UTC 
See patch.
Comment 1 Florian Müllner 2018-02-19 00:59:17 UTC 
Created attachment 368538 [details] [review]
revision-walker: Take a reference on repository property

GObjects should almost always own a reference to ref-counted properties;
there's no apparent reason to make an exception here.
Comment 2 Ignacio Casal Quinteiro (nacho) 2018-02-19 15:31:06 UTC 
Review of attachment 368538 [details] [review]:

Well... taking the ref is fine for me, but you should dispose it no?
Comment 3 Florian Müllner 2018-02-19 15:38:21 UTC 
Created attachment 368565 [details] [review]
revision-walker: Take a reference on repository property

Eeeks, you are right of course!
Comment 4 Ignacio Casal Quinteiro (nacho) 2018-02-19 22:25:55 UTC 
Review of attachment 368565 [details] [review]:

Looks good
Comment 5 Florian Müllner 2018-02-19 23:06:00 UTC 
Attachment 368565 [details] pushed as b7fc9eb - revision-walker: Take a reference on repository property