Created attachment 368434 [details] [review]
smbbrowse: Avoid "Error: Success" failure messages

Save the failed errno as soon as possible to avoid "Error: Success" type
of messages.

Review of attachment 368434 [details] [review]:

Looks ok, thanks, just please use errsv variable instead of errno_save as on other places! Feel free to push with that change.

Seems that the same issue is also in the smb backend, can you please prepare a patch for it also?

Created attachment 369088 [details] [review]
smbbrowse: Avoid "Error: Success" failure messages

Updated as per the review...

Created attachment 369089 [details] [review]
smb: Avoid "Error: Success" failure messages

Attachment 369088 [details] pushed as 20e2a96 - smbbrowse: Avoid "Error: Success" failure messages
Attachment 369089 [details] pushed as 84e95d8 - smb: Avoid "Error: Success" failure messages

Btw, you can still get this error, because smbc_opendir can return NULL and do not set errno obviously... :-(

https://bugzilla.redhat.com/show_bug.cgi?id=1513394#c2

Thanks for finishing up the work, as usual, I got stuck doing other things.
The patch was one for Bigon to test out, but it seems he didn't have time to.

(In reply to Ondrej Holy from comment #6)
> Btw, you can still get this error, because smbc_opendir can return NULL and
> do not set errno obviously... :-(
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1513394#c2

Maybe check for errno being 0 and use a different error message?

(In reply to Bastien Nocera from comment #7)
> Thanks for finishing up the work, as usual, I got stuck doing other things.
> The patch was one for Bigon to test out, but it seems he didn't have time to.
> 
> (In reply to Ondrej Holy from comment #6)
> > Btw, you can still get this error, because smbc_opendir can return NULL and
> > do not set errno obviously... :-(
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1513394#c2
> 
> Maybe check for errno being 0 and use a different error message?

Filed https://bugzilla.gnome.org/show_bug.cgi?id=793911