Created attachment 368408 [details] [review]
lib: Fix possible crash on startup

Fix possible crash when the object creation is cancelled on startup. We
shouldn't be using user_data until we know that the call has not been
cancelled, otherwise we could be accessing already freed memory.

 #0  g_type_check_instance_cast (type_instance=type_instance@entry=0x208dc60, iface_type=34189312) at /home/hadess/Projects/jhbuild/glib/gobject/gtype.c:4057
 #1  0x00007f34c8d09522 in object_manager_new_callback (source_object=<optimized out>, res=0x208c390, user_data=user_data@entry=0x208dc60)
     at ../../../../Projects/jhbuild/gnome-bluetooth/lib/bluetooth-client.c:761
 #2  0x00007f34ce7d819a in g_task_return_now (task=0x208c390) at /home/hadess/Projects/jhbuild/glib/gio/gtask.c:1148
 #3  0x00007f34ce7d81d9 in complete_in_idle_cb (task=task@entry=0x208c390) at /home/hadess/Projects/jhbuild/glib/gio/gtask.c:1162

Created attachment 368409 [details] [review]
lib: Make ObjectManager creation cancellable

So that we can stop the creation as soon as the BluetoothClient
is disposed of, rather than waiting for the call to finish.

Review of attachment 368409 [details] [review]:

lgtm

Review of attachment 368408 [details] [review]:

could clear the cancellable, but that isn't really an issue

(In reply to Benjamin Berg from comment #4)
> Review of attachment 368408 [details] [review] [review]:
> 
> could clear the cancellable, but that isn't really an issue

We could, but we could use it for other internal calls (if we add more) that don't have their own cancellables.

Attachment 368408 [details] pushed as c5190d3 - lib: Fix possible crash on startup
Attachment 368409 [details] pushed as 3f109f3 - lib: Make ObjectManager creation cancellable