After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793406 - Since 1.1 release, buildtime dependency on git?
Since 1.1 release, buildtime dependency on git?
Status: RESOLVED FIXED
Product: msitools
Classification: Other
Component: gcab
git
Other Linux
: Normal normal
: 1.0
Assigned To: msitools maintainer(s)
msitools maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-02-12 22:14 UTC by Bjørn Lie
Modified: 2018-02-13 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Bjørn Lie 2018-02-12 22:14:33 UTC 
Since 1.1 release a buildtime dependency on git is needed.

https://git.gnome.org/browse/gcab/commit/?id=9e4f91f955eb3be3de483fc37e2ac2be887eb6ac

This is probably a bit to much to ask :-)

I fully get the need for --version to work even when building from a git checkout, but to mandate git in a buildroot for a released tarball seems overkill to me.

Building 1.1 with the patch reverted works just fine

bjolie@haldis:~> gcab --version
gcab 1.1
bjolie@haldis:~>
Comment 1 Marc-Andre Lureau 2018-02-13 10:26:11 UTC 
Sorry I forgot to test when git was missing (I checked when it returned error only).

I am looking for a workaround, but I think it would not be crazy to require git in a build system. Stay tuned.
Comment 2 Marc-Andre Lureau 2018-02-13 10:50:29 UTC 
Pushed:

build-sys: don't require git to build
Check git is available before running it.

https://git.gnome.org/browse/gcab/commit/?id=b9972fb3329c2b170132a51694b06d0d8189efd5

thanks
Comment 3 Bjørn Lie 2018-02-13 10:56:50 UTC 
Tested ok!

Thanks a lot for that very quick fix.