After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793388 - build-sys: fix installing the includes
build-sys: fix installing the includes
Status: RESOLVED FIXED
Product: msitools
Classification: Other
Component: gcab
unspecified
Other Linux
: Normal normal
: 1.0
Assigned To: msitools maintainer(s)
msitools maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-02-12 14:38 UTC by Timo Gurr
Modified: 2018-02-12 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gcab-pr1.patch (756 bytes, patch)
2018-02-12 14:38 UTC, Timo Gurr 		committed Details | Review

Description Timo Gurr 2018-02-12 14:38:17 UTC 
Created attachment 368261 [details] [review]
gcab-pr1.patch

https://wiki.gnome.org/msitools states "Forking and sending github pull requests is also welcome." However I'm not sure if you got the notification of the pending pull request: https://github.com/GNOME/gcab/pull/1

Attached is the patch as well.
Comment 1 Marc-Andre Lureau 2018-02-12 15:30:13 UTC 
(In reply to Timo Gurr from comment #0)
> Created attachment 368261 [details] [review] [review]
> gcab-pr1.patch
> 
> https://wiki.gnome.org/msitools states "Forking and sending github pull
> requests is also welcome." However I'm not sure if you got the notification
> of the pending pull request: https://github.com/GNOME/gcab/pull/1

Nope, we don't use github mirror (sadly, no way to disable pull request there...)

> 
> Attached is the patch as well.

thanks, reviewiing