After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793386 - mesa gallium vendor string changed, doesn't match whitelist anymore
mesa gallium vendor string changed, doesn't match whitelist anymore
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-12 14:06 UTC by Christoph Haag
Modified: 2018-02-13 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugins: update mesa's vendor string in whitelist (1.00 KB, patch)
2018-02-12 18:03 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Christoph Haag 2018-02-12 14:06:51 UTC 
The whitelist is hardcoded in  gstreamer-vaapi/gst/vaapi/gstvaapipluginutil.c

  static const gchar *whitelist[] = {
    "Intel i965 driver",
    "mesa gallium vaapi",
    NULL
};


Mesa's new vendor string includes the mesa version and I think the driver name.
Relevant git commit: https://cgit.freedesktop.org/mesa/mesa/commit/?id=5db29d62ce1fefa3f2ee6e4a4688576fde4bde4a
Comment 1 Víctor Manuel Jáquez Leal 2018-02-12 18:03:06 UTC 
Created attachment 368274 [details] [review]
plugins: update mesa's vendor string in whitelist

Mesa has updated its VA-API Gallium driver vendor string:

https://cgit.freedesktop.org/mesa/mesa/commit/?id=5db29d62ce1fefa3f2ee6e4a4688576fde4bde4a

This patch tries to cover both, the old and the new one.
Comment 2 Víctor Manuel Jáquez Leal 2018-02-12 18:03:33 UTC 
@Christoph:

does this work for you?
Comment 3 Christoph Haag 2018-02-12 20:53:36 UTC 
It does indeed work for me.

Are there incompatible implementations so that the whitelist for only mesa is definitely needed?
Comment 4 Víctor Manuel Jáquez Leal 2018-02-13 07:54:51 UTC 
(In reply to Christoph Haag from comment #3)
> It does indeed work for me.
> 
> Are there incompatible implementations so that the whitelist for only mesa
> is definitely needed?

Yes, the main problematic one is the VDPAU bridge, which is unmantained.
Comment 5 Víctor Manuel Jáquez Leal 2018-02-13 16:07:19 UTC 
Attachment 368274 [details] pushed as 19fe5c4 - plugins: update mesa's vendor string in whitelist