GNOME Bugzilla – Bug 793345
Typo in man page for gvfsd
Last modified: 2018-02-15 12:46:04 UTC
Hello, I'm running CentOS 7.4.1708, fully updated, and have gvfs.x86_64 installed, Version: 1.30.4 Release: 3.el7 I believe this problem affects even the latest github version. I visited: https://github.com/GNOME/gvfs/blob/master/man/gvfsd.xml And noticed, just like in the man page for gvfsd, there's a type. In the xml file, it's on line 51 of the xml file. Line 51 shows: when requested and keeps track fo their lifecycle, I believe the letters "fo" should be switched around to show "of" so the statement reads: when requested and keeps track of their lifecycle, When I type man gvfsd, I see the typo in the man page as well. That's how I noticed it. I just went to the github page to see if it had been fixed yet. Thanks!
Created attachment 368201 [details] [review] Fixes a typo in the gvfsd man page. I tried, unsuccessfully, using git-bz to submit the patch. I followed the directions here: http://git.fishsoup.net/man/git-bz.html But it errors out every time, so I've submitted a patch the old fashioned way for review. The patch simply switches the fo to an of. I hope this is acceptable.
Comment on attachment 368201 [details] [review] Fixes a typo in the gvfsd man page. rom 7b7049c7e9bae239653cb180fa7c0252ed70913c Mon Sep 17 00:00:00 2001 From: Spork Schivago <SporkSchivago@gmail.com> Date: Fri, 9 Feb 2018 20:18:06 -0500 Subject: [PATCH] man/gvfsd.xml: Fixed a type in the man page for gvfsd. In the gvfsd man page, there is a typo. The word 'of' is spelled 'fo'. To fix this situation, I switched the two letters around. https://bugzilla.gnome.org/show_bug.cgi?id=793345 --- man/gvfsd.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/gvfsd.xml b/man/gvfsd.xml index 9d58c34..0abe7a5 100644 --- a/man/gvfsd.xml +++ b/man/gvfsd.xml @@ -48,7 +48,7 @@ <para>The primary task of <command>gvfsd</command> is to act as a mount tracker/manager. It spawns new backends - when requested and keeps track fo their lifecycle, + when requested and keeps track of their lifecycle, maintaining a list of active mounts and creates direct connections to them.</para> -- 1.8.3.1
Review of attachment 368201 [details] [review]: Thanks for the patch. The reason, why "git bz" did not work to you, is probably the fact, that you did not commit your changes locally. The right way to create patch is using "git commit" and "git format-patch", see: https://wiki.gnome.org/Git/WorkingWithPatches Are you interested in updating the patch so it will contain your authorship and some meaningful commit message? Or should I do it myself?
(In reply to Ondrej Holy from comment #3) > Review of attachment 368201 [details] [review] [review]: > > Thanks for the patch. The reason, why "git bz" did not work to you, is > probably the fact, that you did not commit your changes locally. The right > way to create patch is using "git commit" and "git format-patch", see: > https://wiki.gnome.org/Git/WorkingWithPatches > > Are you interested in updating the patch so it will contain your authorship > and some meaningful commit message? Or should I do it myself? Thank you for the reply, but I did commit locally and added a message. I also followed that link and setup git how they said to. I did not clone the whole repository for git bz. I only downloaded the program. I'm using Chrome-stable, the official Chrome, not Chromium, but git bz says it supports Chrome now. I also used the git format-patch, but git bz attach nnnnnn HEAD (where nnnnnn is this bug number 793345, fails, with an error message about SQLLite or something). If you want, I can paste the error here. That's where the second patch came from. I couldn't figure out how to delete it, but it said if I couldn't submit via git bz, I could manually submit it. I messed it up though. But that's the "formated" patch, with the commit message in the proper format I believe. If I could figure out how to update the patch myself, I'd do it, but I couldn't figure out how to edit it once it was uploaded. If you don't mind doing it, I'd greatly appreciate it. Thank you.
Ah, I overlooked that you added the format-patch to the comment. But it is possible to edit the attachment over [details] -> (edit details), or simply mark the attachment as obsolete and upload new one instead... nevermind... I am going to push it this way this time (with a small change in the commit message). Thanks for your contribution!
Created attachment 368313 [details] [review] man: Fix a typo in the gvfsd man page In the gvfsd man page, there is a typo. The word 'of' is spelled 'fo'. To fix this situation, I switched the two letters around.
Attachment 368313 [details] pushed as 0a3d911 - man: Fix a typo in the gvfsd man page
(In reply to Ondrej Holy from comment #5) > Ah, I overlooked that you added the format-patch to the comment. But it is > possible to edit the attachment over [details] -> (edit details), or simply > mark the attachment as obsolete and upload new one instead... nevermind... I > am going to push it this way this time (with a small change in the commit > message). Thanks for your contribution! Thank you, and for the git-formatted patch that I posted as a comment, instead of as an attachment like I wanted, I cannot edit what I want though. I can edit the actual diff patch part, but if you notice this line: rom 7b7049c7e9bae239653cb180fa7c0252ed70913c Mon Sep 17 00:00:00 2001 It should actually read: From 7b7049c7e9bae239653cb180fa7c0252ed70913c Mon Sep 17 00:00:00 2001 I can't figure out how to add the 'F' there. When I copied and pasted it, I guess I didn't highlight the whole patch. This is my first attempt at submitting a patch for Bugzilla, so I do apologize. Thank you for helping me figure out how to submit one properly.
Yes, it is possible to edit attachments, but comments aren't editable, unfortunately. I've added the missing "F" when applying the patch. I am happy for your contribution anyway!
I am very happy for you accepting my patch, I was almost certain it'd be denied. Thank you! I believe we can close this bug now and mark it as fixed, seeing how the commit has now been pushed upstream. Thank you again for helping me through this process. It was fairly painless!