Bug 793302 – libnm-util: Fix a minor type problem with GValue

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 793302 - libnm-util: Fix a minor type problem with GValue


Summary:	libnm-util: Fix a minor type problem with GValue


Status:	RESOLVED FIXED

Product:	NetworkManager
Classification:	Platform
Component:	general
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	NetworkManager maintainer(s)
QA Contact:	NetworkManager maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2018-02-08 14:32 UTC by Philip Withnall
Modified:	2018-02-08 16:48 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
libnm-util: Fix a minor type problem with GValue (1.31 KB, patch) 2018-02-08 14:32 UTC, Philip Withnall	none	Details \| Review

Description Philip Withnall 2018-02-08 14:32:50 UTC

Trivial patch attached.

Comment 1 Philip Withnall 2018-02-08 14:32:54 UTC

Created attachment 368150 [details] [review]
libnm-util: Fix a minor type problem with GValue

The code was passing the gpointer alias of the GValue, rather than the
GValue* itself. This doesn’t matter normally, but broke an experimental
patch in GLib to remove a cast from G_VALUE_TYPE.

We’ve reverted the patch in GLib (see
https://bugzilla.gnome.org/show_bug.cgi?id=793186), but this should be
fixed in NetworkManager anyway.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Comment 2 Thomas Haller 2018-02-08 16:48:52 UTC

Merged

master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=daadb8fbe96558e8de768518aaf130cb0cff0abe

nm-1-10: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=338b4e6b2123d531cadc9fa01180a7a9fe9957e1


Thanks!