GNOME Bugzilla – Bug 793281
Consider whether the gnutls-pkcs11 backend should still exist
Last modified: 2018-05-29 06:36:09 UTC
The gnutls-pkcs11 backend of glib-networking is only used when the user explicitly sets the environment variable GIO_USE_TLS=gnutls-pkcs11. Since it's not enabled by default, it's not clear to me if it is really useful to keep around. I suspect that almost nobody is using this code. If we keep it around, we should: * Test https://git.gnome.org/browse/glib-networking/commit/?id=5d0dcfd2bd85773e090008a7b1e1f28b9dbe9840. (The testsuite passed, but it passes even when I sabotage some of those function calls.) * Fix bug #793280 * Somehow enable its use by default, so setting an environment variable is not required for this code to be useful In the meantime, it's a big component of glib-networking that I'm not planning to work on myself.
Also note that, as part of bug #753260, the non-PKCS#11 backend will now be using the p11-kit trust store by default on systems where that is configured as GnuTLS's default trust store, such as Fedora.
Created attachment 372318 [details] [review] Disable building PKCS#11 backend by default This backend has never been enabled at runtime, except when the GIO_USE_TLS=gnutls-pkcs11 environment variable is set. I'm quite uncertain as to whether it should continue to exist or not. So let's disable it. If nobody complains, I'll probably delete the code, but let's keep the code around for now to be on the safe side.
Comment on attachment 372318 [details] [review] Disable building PKCS#11 backend by default Attachment 372318 [details] pushed as 9cc21be - Disable building PKCS#11 backend by default
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1336.
Reopening. This bug was migrated to https://gitlab.gnome.org/GNOME/glib, but it should have been migrated to https://gitlab.gnome.org/GNOME/glib-networking.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib-networking/issues/7.