After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793267 - No option to mark complete url by touch
No option to mark complete url by touch
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
3.27.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-07 17:35 UTC by Jan-Michael Brummer
Modified: 2018-02-07 21:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch adding longpress gesture (2.33 KB, patch)
2018-02-07 17:46 UTC, Jan-Michael Brummer 		none Details | Review
Patch adding longpress gesture (2.34 KB, patch)
2018-02-07 17:48 UTC, Jan-Michael Brummer 		none Details | Review
Patch adding longpress gesture - V2 (2.66 KB, patch)
2018-02-07 19:42 UTC, Jan-Michael Brummer 		committed Details | Review

Description Jan-Michael Brummer 2018-02-07 17:35:49 UTC 
Currently a touch screen user has no easy option to mark the whole url text for deleting as it is provided by other touch based system. This makes it very frustating as the user has to remove each character or mark the whole text using the toolbox.

An easier option would be to provide a longpress gesture for the location entry to mark the complete text.
Comment 1 Jan-Michael Brummer 2018-02-07 17:46:53 UTC 
Created attachment 368079 [details] [review]
Patch adding longpress gesture
Comment 2 Jan-Michael Brummer 2018-02-07 17:48:44 UTC 
Created attachment 368081 [details] [review]
Patch adding longpress gesture
Comment 3 Michael Catanzaro 2018-02-07 19:32:30 UTC 
Review of attachment 368081 [details] [review]:

::: src/ephy-location-controller.c
@@ +400,3 @@
     return;
 
+  longpress_gesture = gtk_gesture_long_press_new (widget);

Surely it needs to be freed somewhere? How is that supposed to work?
Comment 4 Jan-Michael Brummer 2018-02-07 19:42:46 UTC 
Created attachment 368094 [details] [review]
Patch adding longpress gesture - V2

Add longpress object clearing
Comment 5 Michael Catanzaro 2018-02-07 21:22:05 UTC 
Review of attachment 368094 [details] [review]:

::: src/ephy-location-controller.c
@@ +402,3 @@
+  controller->longpress_gesture = gtk_gesture_long_press_new (widget);
+  gtk_gesture_single_set_touch_only (GTK_GESTURE_SINGLE (controller->longpress_gesture), TRUE);
+  g_signal_connect (controller->longpress_gesture, "pressed", G_CALLBACK(longpress_gesture_cb), controller);

Oops, I missed that there is a missing space after G_CALLBACK. I'll push a fixup.