After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793179 - Build failure on GNOME Continuous
Build failure on GNOME Continuous
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-05 10:06 UTC by Emmanuele Bassi (:ebassi)
Modified: 2018-02-05 22:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix non-srcdir builds (1.60 KB, patch)
2018-02-05 10:16 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2018-02-05 10:06:03 UTC 
Commit f1c46cb52560db106b85a93346c8bcf340ac05f1 breaks the build on the CI pipeline:

XMLLINT=/usr/bin/xmllint /usr/bin/glib-compile-resources --target terminal-resources.c --sourcedir ../../src --generate --c-name terminal ../../src/terminal.gresource.xml
XMLLINT=/usr/bin/xmllint /usr/bin/glib-compile-resources --target terminal-resources.h --sourcedir ../../src --generate --c-name terminal ../../src/terminal.gresource.xml
../../src/terminal.gresource.xml: Failed to locate “terminal-menubar-with-mnemonics.ui” in any source directory.
../../src/terminal.gresource.xml: Failed to locate “terminal-menubar-with-mnemonics.ui” in any source directory.
Makefile:2436: recipe for target 'terminal-resources.h' failed
Comment 1 Emmanuele Bassi (:ebassi) 2018-02-05 10:16:57 UTC 
Created attachment 367900 [details] [review]
Fix non-srcdir builds

If we are including generated files inside a GResource manifest we need
to add $(builddir) to the source directories for glib-compile-resources,
both for the dependency discovery and for the actual generation.
Comment 2 Emmanuele Bassi (:ebassi) 2018-02-05 10:18:14 UTC 
Pushed without review to unblock the CI pipeline.

Attachment 367900 [details] pushed as 03156bc - Fix non-srcdir builds
Comment 3 Christian Persch 2018-02-05 22:20:45 UTC 
Thanks for the fix!