After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793133 - Using eyedropper causes GIMP debug error
Using eyedropper causes GIMP debug error
Status: RESOLVED NOTGNOME
Product: GIMP
Classification: Other
Component: Tools
git master
Other Linux
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
https://bugs.kde.org/show_bug.cgi?id=...
Depends on:
Blocks:
 
 
Reported: 2018-02-03 08:07 UTC by Ankush Patel
Modified: 2018-02-04 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ankush Patel 2018-02-03 08:07:27 UTC
Using the eyedropper tool causes an error in GIMP, and the "GIMP Debug" dialog pops up.
The image was opened from a file manager (Dolphin), not from within GIMP itself (i.e. right clicking on image > open with GIMP). The desktop environment is KDE. 

To reproduce bring up the "Change Foreground Colour" dialog, and select the  eyedropper tool. The "GIMP Debug" dialog will immediately open.

The contents of the debug dialog are pasted below:

GNU Image Manipulation Program version 2.9.9
git-describe: GIMP_2_9_8-453-g1750d97b11
C compiler:
	Using built-in specs.
	COLLECT_GCC=gcc
	COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/7.2.1/lto-wrapper
	Target: x86_64-pc-linux-gnu
	Configured with: /build/gcc/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared --enable-threads=posix --enable-libmpx --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --enable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp
	Thread model: posix
	gcc version 7.2.1 20180116 (GCC) 
	
using GEGL version 0.3.29 (compiled against version 0.3.29)
using GLib version 2.54.3 (compiled against version 2.54.3)
using GdkPixbuf version 2.36.10 (compiled against version 2.36.10)
using GTK+ version 2.24.32 (compiled against version 2.24.32)
using Pango version 1.40.13 (compiled against version 1.40.13)
using Fontconfig version 2.12.6 (compiled against version 2.12.6)
using Cairo version 1.15.10 (compiled against version 1.15.10)


> GIMP-Warning: KWin backend for color picking failed with error: GDBus.Error:org.kde.kwin.ColorPicker.Error.Cancelled: Color picking got cancelled

Stack trace:
[New LWP 25871]
[New LWP 25872]
[New LWP 25873]
[New LWP 25900]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
0x00007fba5cf8c7b3 in select () from /usr/lib/libc.so.6
  • #0 select
  • #1 g_spawn_sync
  • #2 0x00005560d318ff10 in
  • #3 0x00005560d31901ce in
  • #4 g_logv
  • #5 g_log
  • #6 _gimp_pick_button_kwin_pick
  • #7 g_closure_invoke
  • #8 0x00007fba5daf8c28 in
  • #9 g_signal_emit_valist
  • #10 g_signal_emit
  • #11 0x00007fba613c4895 in
  • #12 g_closure_invoke
  • #13 0x00007fba5daf8c28 in
  • #14 g_signal_emit_valist
  • #15 g_signal_emit
  • #16 0x00007fba613c37ba in
  • #17 0x00007fba6146c7cc in
  • #18 g_closure_invoke
  • #19 0x00007fba5daf85aa in
  • #20 g_signal_emit_valist
  • #21 g_signal_emit
  • #22 0x00007fba61587235 in
  • #23 gtk_propagate_event
  • #24 gtk_main_do_event
  • #25 0x00007fba610e3d5e in
  • #26 g_main_context_dispatch
  • #27 0x00007fba5d80b081 in
  • #28 g_main_loop_run
  • #29 app_run
  • #30 main

Comment 1 Jehan 2018-02-03 15:57:27 UTC
Hello Ankush,

I think that's a known bug (though I didn't make a bug report for it back then). Is your KDE version 5.10 by any chance? I had the same bug when I implemented color-picking, but KDE developers told me that 5.10 is no longer maintained (why is it used in the last Fedora version then, I wonder! Fedora is supposed to be state-of-the-art!) and that this bug is apparently fixed on newer versions of KDE.

See https://bugs.kde.org/show_bug.cgi?id=387720

My code actually already has a fallback to the X11 backend when this failure happens, so the color picking should still work, provided you are on KDE/X11 (on KDE/Wayland, it won't with this version of KDE).

Are you on X11? If so, can you confirm that even though the warning got outputted, the color was correctly picked?

So basically, there is not much we can do about this because it's a KDE bug, and we got a X11 fallback so color-picking should still work on X11.

Of course, the debug dialog is still annoying but we only output it on WARNINGs in development versions of GIMP (on stable versions, it will only output CRITICAL and over).
Maybe I should make some option for this though. In the meantime, you can deactivate the debug tool altogether in the preferences so that you can use the color picker without enabling debug every time.
Comment 2 Ankush Patel 2018-02-03 20:57:00 UTC
Hi, thanks for the response. The version of KDE I am using is 5.11.5 (Archlinux). I am running on X11, not Wayland, however I can confirm that the colour picking does work correctly, despite the warning. I also noticed that performing the same task using the colour picker (from the toolbox directly, not the colour selection dialog) does not produce the warning. I think I will disable the dialog for now, but an option would be good.

Thanks.
Comment 3 Jehan 2018-02-03 21:15:42 UTC
(In reply to Ankush Patel from comment #2)
> Hi, thanks for the response. The version of KDE I am using is 5.11.5
> (Archlinux).

Ok thanks. Anyway KDE developers don't say exactly from which version it was fixed (it doesn't look like they know; they just told me it works on their machine and that 5.10 is deprecated).

What you can do to confirm is:

* Install d-feet (this is a graphics tool to run dbus API, mostly for debugging I'd say);
* Find the pick() API for the org.kde.kwin.ColorPicker interface under org.kde.KWin > /ColorPicker. See my screenshot:
https://bugsfiles.kde.org/attachment.cgi?id=109264
* Double click the API then click "Execute".

You will normally get the error:

> GDBus.Error:org.kde.kwin.ColorPicker.Error.Cancelled: Color picking got cancelled

That will confirm that the bug is still in KDE 5.11.5.

What you can do is then to comment on the KDE bug report I opened (https://bugs.kde.org/show_bug.cgi?id=387720) and tell them that you can also reproduce the bug in KDE 5.11.5. It would be nice to get a bit of visibility on this bug.

> I am running on X11, not Wayland, however I can confirm that
> the colour picking does work correctly, despite the warning. I also noticed

As expected. That's because I fallback to X11 color picking when the dbus API fails (which also means that it won't work at all on KDE/Wayland).

> that performing the same task using the colour picker (from the toolbox
> directly, not the colour selection dialog) does not produce the warning. I
> think I will disable the dialog for now, but an option would be good.

Yes. I will add an option for a bit more subtle settings on when you want this debug dialog or not.

> Thanks.

You are welcome!
Comment 4 Jehan 2018-02-04 17:43:36 UTC
Looks like it finally happened thanks to your message. They now even got a patch now, so I assume the upstream bug report will also close as FIXED soon.
Basically it seems they simply forgot to implement the feature on X11!

Closing this one as NOTGNOME.