After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793119 - omx: fix makefile error while building test for gst-omx
omx: fix makefile error while building test for gst-omx
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other other
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-02 10:59 UTC by Jeegar
Modified: 2018-11-03 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
omx: fix build error for gst-omx tests (1.01 KB, patch)
2018-02-02 11:07 UTC, Jeegar
none Details | Review

Description Jeegar 2018-02-02 10:59:58 UTC
While building latest master branch of gst-omx under Yocto build, I get below error.

| tests/check/Makefile.am:22: error: AM_TESTS_ENVIRONMENT must be set with '=' before using '+='
Comment 1 Jeegar 2018-02-02 11:07:50 UTC
Created attachment 367801 [details] [review]
omx: fix build error for gst-omx tests

In GNU makefile, An Variable needs to be set with '='
first before using '+='

Here AM_TESTS_ENVIRONMENT is being used first time so
need to set with '='
Comment 2 Tim-Philipp Müller 2018-02-02 12:27:00 UTC
Thanks for the patch, but this doesn't look quite right.

I don't think this should be required.

AM_TESTS_ENVIRONMENT is set by check.mak from the common submodule which is included at the top of tests/check/Makefile.am

I just checked our tarball which does include the common subdir, so don't know what's going on. I suspect something yocto specific.
Comment 3 GStreamer system administrator 2018-11-03 13:01:48 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-omx/issues/19.