After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793091 - Can't go back from Trash when I don't have any notes
Can't go back from Trash when I don't have any notes
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-02-01 13:28 UTC by Debarshi Ray
Modified: 2018-02-05 22:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix back button from trash view (2.06 KB, patch)
2018-02-02 03:09 UTC, Mohammed Sadiq 		committed Details | Review

Description Debarshi Ray 2018-02-01 13:28:20 UTC 
I built and ran Bijiben from master (commit 8a3dc1015ec04feb). I don't have any notes, so it came up empty, which is fine. If I click "view trash" from the application menu, it takes me to the "Trash" view, which is also empty, but I can't escape from this view. The back button doesn't do anything.
Comment 1 Mohammed Sadiq 2018-02-02 03:09:42 UTC 
Created attachment 367783 [details] [review]
Fix back button from trash view

The back button wasn't working properly after the user switched
to trash view (only when with empty note in main view).

This commit fixes the issue by switching to the right view
when the back button is pressed.
Comment 2 Isaque Galdino 2018-02-05 22:16:03 UTC 
Review of attachment 367783 [details] [review]:

lgtm.