After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792949 - Zoom level does not show values in between
Zoom level does not show values in between
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 772052 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2018-01-27 09:57 UTC by Jan-Michael Brummer
Modified: 2018-02-02 19:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixing zoom levels (4.31 KB, patch)
2018-01-27 10:00 UTC, Jan-Michael Brummer 		accepted-commit_now Details | Review
Patch fixing zoom levels - V2 (4.32 KB, patch)
2018-01-29 15:20 UTC, Jan-Michael Brummer 		committed Details | Review

Description Jan-Michael Brummer 2018-01-27 09:57:13 UTC 
Currently the zoom level buttons uses a fixed table of zoom levels. This leads to an empty text on zoom level button when using a zooming gesture iff the value is falling in-between the supported table range.
Comment 1 Jan-Michael Brummer 2018-01-27 10:00:09 UTC 
Created attachment 367511 [details] [review]
Patch fixing zoom levels

This patch simplifies the zooming code to rely on webkit only. Zoom in/out are set in 0.25 steps with a minimum and maximum border. It further more fixes missing zoom level text when using touch gestures.
Comment 2 Michael Catanzaro 2018-01-28 22:29:00 UTC 
Review of attachment 367511 [details] [review]:

I was confused why you were able to remove most of these functions without breaking anything in EphyWebView... turns out it is ignoring EphyZoom entirely and just calling the WebKit functions directly to manage the zoom level....

::: src/ephy-window.c
@@ +1012,3 @@
   double zoom;
   GtkWidget *zoom_level_button;
+  g_autofree gchar *zoom_level;

I've been thinking it's about time to start using g_autoptr in Epiphany, but we haven't yet, and let's not start now with this patch. It's good if you change this.
Comment 3 Jan-Michael Brummer 2018-01-29 15:20:52 UTC 
Created attachment 367577 [details] [review]
Patch fixing zoom levels - V2

Patch without g_autofree
Comment 4 Jan-Michael Brummer 2018-01-30 18:42:51 UTC 
*** Bug 772052 has been marked as a duplicate of this bug. ***