GNOME Bugzilla – Bug 792940
Combo box does not open in dual screen setup
Last modified: 2018-01-29 14:34:32 UTC
Within a dual screen setup epiphanys own implementation of combobox does not open on the screen next to primary (0/0) screen. This is caused by computing the wrong x value of the popup.
Created attachment 367490 [details] [review] Patch fixing option box
Review of attachment 367490 [details] [review]: ::: embed/ephy-option-menu.c @@ +586,2 @@ gtk_widget_get_preferred_size (GTK_WIDGET (menu), &menu_req, NULL); + if (x + menu_req.width > area.x + area.width) So... are x and area.x using values from two separate coordinate systems? Is x given in "global coordinates" taking into consideration both monitors, while area.x is given in monitor-specific coordinates? My concern is that this check might not be right either, if the check you removed is not right. And then what about the y coordinate checks below? I assume that will break if you stack monitors vertically instead of horizontally, right?
Well, beside my trust in code i double checked it with all configurations: - Left/Right/Up/Down with Primary/Secondary configuration both on a dual screen setup using Wayland and X Everything works as expected now.
And sorry for not answering your question: those values are monitor specific.
This code was copied from gtkcombobox.c, so we should do the same thing than GTK+. Are GTK+ combo boxes working fine for you?
Yes, gtk combobox has been changed to gtk_menu_popup_xxx function.
(In reply to Jan-Michael Brummer from comment #6) > Yes, gtk combobox has been changed to gtk_menu_popup_xxx function. So can we use that...?
Not yet, as they have a menu and we have a treeview with a window. Why is that btw? Could it be switched to gmenu?
(In reply to Jan-Michael Brummer from comment #8) > Not yet, as they have a menu and we have a treeview with a window. Why is > that btw? Could it be switched to gmenu? I'll let Carlos answer this