After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792929 - Safe browsing data should use the default profile directory
Safe browsing data should use the default profile directory
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-26 12:36 UTC by Michael Catanzaro
Modified: 2018-01-27 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
embed-shell: Use the default profile directory for the GSB database (1.29 KB, patch)
2018-01-26 23:33 UTC, Gabriel Ivașcu
committed Details | Review

Description Michael Catanzaro 2018-01-26 12:36:18 UTC
Since safe browsing data is 200 GB large it should always be saved to and read from the default profile directory, that way there is not a separate copy of it for every web app in existence.
Comment 1 Gabriel Ivașcu 2018-01-26 23:33:00 UTC
Created attachment 367492 [details] [review]
embed-shell: Use the default profile directory for the GSB database
Comment 2 Gabriel Ivașcu 2018-01-26 23:35:25 UTC
Should we also have a migrator to delete the current GSB database from the previous profile directory?
Comment 3 Gabriel Ivașcu 2018-01-26 23:38:57 UTC
(In reply to Michael Catanzaro from comment #0)
> Since safe browsing data is 200 GB large ...
                              ^^^^^^
I think you meant MB there :)
Comment 4 Michael Catanzaro 2018-01-27 01:51:45 UTC
Yeah... 200 GB would be a bit concerning!

(In reply to Gabriel Ivașcu from comment #2)
> Should we also have a migrator to delete the current GSB database from the
> previous profile directory?

Optional, since no stable release users are affected. It's *mostly* harmless to add if you want to, since this should be a very simple migrator. if strcmp (ephy_dot_dir (), ephy_default_dir_dir ()) != 0 then it should delete gsb-threats.db.

I do worry that we are adding too many migrators; each migrator has a risk (e.g. bug #792683)> But this one should be super simple and safe.
Comment 5 Michael Catanzaro 2018-01-27 01:58:08 UTC
Review of attachment 367492 [details] [review]:

Thanks
Comment 6 Michael Catanzaro 2018-01-27 01:58:34 UTC
(In reply to Michael Catanzaro from comment #4)
> if strcmp (ephy_dot_dir (), ephy_default_dir_dir ()) != 0 then it should delete
> gsb-threats.db.

Actually there is ephy_dot_dir_is_default() that would be better to use.
Comment 7 Gabriel Ivașcu 2018-01-27 11:55:21 UTC
Attachment 367492 [details] pushed as 9db8e65 - embed-shell: Use the default profile directory for the GSB database