GNOME Bugzilla – Bug 792929
Safe browsing data should use the default profile directory
Last modified: 2018-01-27 11:55:25 UTC
Since safe browsing data is 200 GB large it should always be saved to and read from the default profile directory, that way there is not a separate copy of it for every web app in existence.
Created attachment 367492 [details] [review] embed-shell: Use the default profile directory for the GSB database
Should we also have a migrator to delete the current GSB database from the previous profile directory?
(In reply to Michael Catanzaro from comment #0) > Since safe browsing data is 200 GB large ... ^^^^^^ I think you meant MB there :)
Yeah... 200 GB would be a bit concerning! (In reply to Gabriel Ivașcu from comment #2) > Should we also have a migrator to delete the current GSB database from the > previous profile directory? Optional, since no stable release users are affected. It's *mostly* harmless to add if you want to, since this should be a very simple migrator. if strcmp (ephy_dot_dir (), ephy_default_dir_dir ()) != 0 then it should delete gsb-threats.db. I do worry that we are adding too many migrators; each migrator has a risk (e.g. bug #792683)> But this one should be super simple and safe.
Review of attachment 367492 [details] [review]: Thanks
(In reply to Michael Catanzaro from comment #4) > if strcmp (ephy_dot_dir (), ephy_default_dir_dir ()) != 0 then it should delete > gsb-threats.db. Actually there is ephy_dot_dir_is_default() that would be better to use.
Attachment 367492 [details] pushed as 9db8e65 - embed-shell: Use the default profile directory for the GSB database