After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792910 - qtdemux: improve comment of gst_qtdemux_find_sample()
qtdemux: improve comment of gst_qtdemux_find_sample()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-25 20:26 UTC by Alicia Boya García
Modified: 2018-01-25 20:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: Add more prose to the comment of gst_qtdemux_find_sample() (1.61 KB, patch)
2018-01-25 20:26 UTC, Alicia Boya García 		committed Details | Review

Description Alicia Boya García 2018-01-25 20:26:13 UTC 
It took me a while to understand what gst_qtdemux_find_sample() does. It had a
comment that explained it but it was so cryptic to me that it did not make any
sense until I read and analyzed the entire code. By then, well... I no longer
had any use of it.

This is my humble attempt for a more precise explanation.
Comment 1 Alicia Boya García 2018-01-25 20:26:17 UTC 
Created attachment 367441 [details] [review]
qtdemux: Add more prose to the comment of gst_qtdemux_find_sample()
Comment 2 Tim-Philipp Müller 2018-01-25 20:41:47 UTC 
Nice improvement, thanks!

commit ac46d5c2a33ff370b73acb87961e030a43b6239a (HEAD -> master)
Author: Alicia Boya García <aboya@igalia.com>
Date:   Thu Jan 25 20:48:42 2018 +0100

    qtdemux: Add more prose to the comment of gst_qtdemux_find_sample()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=792910