After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792845 - test-enumerator-filter fails with assertion failed: (umockdev_in_mock_environment ()) using umockdev 0.9.4 or later
test-enumerator-filter fails with assertion failed: (umockdev_in_mock_environ...
Status: RESOLVED FIXED
Product: libgudev
Classification: Other
Component: General
232
Other Linux
: Normal normal
: ---
Assigned To: libgudev Maintainers
libgudev Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-23 21:11 UTC by James Clarke
Modified: 2018-01-24 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.49 KB, patch)
2018-01-23 21:11 UTC, James Clarke
none Details | Review
tests: Fix test assertion with umockdev (1.47 KB, patch)
2018-01-24 11:57 UTC, Bastien Nocera
committed Details | Review

Description James Clarke 2018-01-23 21:11:11 UTC
Created attachment 367339 [details] [review]
Proposed patch

Since umockdev 0.9.4, rather than checking for libumockdev-preload being in LD_PRELOAD, umockdev_in_mock_environment now checks whether /sys is being redirected. This only occurs when $UMOCKDEV_DIR is set, which happens inside umockdev_testbed_new, so the assertion must come after this call. The attached patch fixes this.
Comment 1 Bastien Nocera 2018-01-24 11:57:42 UTC
Created attachment 367370 [details] [review]
tests: Fix test assertion with umockdev

Since 0.9.4, rather than checking for libumockdev-preload being in
LD_PRELOAD, umockdev_in_mock_environment now checks whether /sys is
being redirected. This only occurs when $UMOCKDEV_DIR is set, which
happens inside umockdev_testbed_new, so the assertion must come after
this call.
Comment 2 Bastien Nocera 2018-01-24 11:58:35 UTC
Tested with an earlier umockdev, and test still passes. Thanks!

Attachment 367370 [details] pushed as bf8664a - tests: Fix test assertion with umockdev