After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792824 - Notes are saved too often
Notes are saved too often
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: Edition
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-01-23 14:28 UTC by Isaque Galdino
Modified: 2018-01-25 02:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
webkit-editor: Remove unneed saving on first load (1.96 KB, patch)
2018-01-23 14:28 UTC, Isaque Galdino
none Details | Review
webkit-editor: Remove unneed saving on first load (1.95 KB, patch)
2018-01-24 19:19 UTC, Isaque Galdino
committed Details | Review

Description Isaque Galdino 2018-01-23 14:28:13 UTC
When you open an existing note, even you don't change it, that note is saved again. That makes the note to go up in the notes list.
Comment 1 Isaque Galdino 2018-01-23 14:28:55 UTC
Created attachment 367316 [details] [review]
webkit-editor: Remove unneed saving on first load

Every time a note is opened, it's triggered an unnecessary saving
action. That changes update times, and changes notes order in main
view. It also increases note load times, mainling for remote notes, like
owncloud.

This patch makes sure that on first load, webkit editor doesn't try to
save the note.
Comment 2 Mohammed Sadiq 2018-01-23 18:12:02 UTC
Review of attachment 367316 [details] [review]:

Commit message review:

> "it's triggered an unnecessary saving action"
"an unnecessary saving action is triggered" may be a better wording?

> "mainling for remote notes, like"
  Did you mean "mainly"?

Otherwise, this seems good. Please push to master after the commit message changes.
Thanks
Comment 3 Isaque Galdino 2018-01-24 19:19:13 UTC
Created attachment 367396 [details] [review]
webkit-editor: Remove unneed saving on first load

Every time a note is opened, unnecessary saving action is triggered.
That changes update times, and changes notes order in main view. It also
increases note load times, mainly for remote notes, like owncloud.

This patch makes sure that on first load, webkit editor doesn't try to
save the note.
Comment 4 Mohammed Sadiq 2018-01-25 02:00:03 UTC
Review of attachment 367396 [details] [review]:

lgtm. Please push to master
Comment 5 Mohammed Sadiq 2018-01-25 02:05:02 UTC
Attachment 367396 [details] pushed as aa8c5c5 - webkit-editor: Remove unneed saving on first load