After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792793 - Add "GNU AGPL 3.0 only" licence
Add "GNU AGPL 3.0 only" licence
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.22.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2018-01-22 18:14 UTC by Stephen
Modified: 2018-02-11 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add AGPL3-only licence to GtkAboutDialog (2.06 KB, patch)
2018-01-23 13:41 UTC, Stephen 		none Details | Review
Add AGPL3-only licence to GtkAboutDialog (2.40 KB, patch)
2018-01-23 13:56 UTC, Stephen 		committed Details | Review

Description Stephen 2018-01-22 18:14:31 UTC 
The other xGPL licences (LGPL, GPL) included in GtkLicense (https://developer.gnome.org/gtk3/stable/GtkAboutDialog.html#GtkLicense) have both "only" and "and later" variants.

Please add a similar "only" variant for AGPL3.
Comment 1 Matthias Clasen 2018-01-22 21:08:13 UTC 
do you have an application where this choice is needed ?
Comment 2 Stephen 2018-01-22 21:10:40 UTC 
Yup.
Comment 3 Matthias Clasen 2018-01-23 13:08:39 UTC 
a patch would be welcome - this should be easy for a newcomer
Comment 4 Stephen 2018-01-23 13:41:49 UTC 
Created attachment 367309 [details] [review]
Add AGPL3-only licence to GtkAboutDialog
Comment 5 Emmanuele Bassi (:ebassi) 2018-01-23 13:44:55 UTC 
Review of attachment 367309 [details] [review]:

Thanks for your patch.

It looks good, but could you please submit a patch generated with `git format-patch` or, better yet, with `git-bz`? Please see: https://wiki.gnome.org/Git/WorkingWithPatches

Thanks again!
Comment 6 Stephen 2018-01-23 13:56:38 UTC 
Created attachment 367312 [details] [review]
Add AGPL3-only licence to GtkAboutDialog
Comment 7 Stephen 2018-01-28 13:51:08 UTC 
Matthias/Emmanuele, can you review the revised patch?
Comment 8 Emmanuele Bassi (:ebassi) 2018-01-28 14:38:28 UTC 
Thanks, pushed to the master branch. I'm going to cherry pick it to the gtk-3-22 branch as well, but it's going to need a "Since" annotation first.

Attachment 367312 [details] pushed as cb5c739 - Add AGPL3-only licence to GtkAboutDialog
Comment 9 Stephen 2018-01-28 14:53:51 UTC 
Great, and the cherry-pick will definitely be useful, thanks :) Presumably you're adding the annotation?
Comment 10 Emmanuele Bassi (:ebassi) 2018-01-28 15:20:03 UTC 
(In reply to Stephen from comment #9)
> Great, and the cherry-pick will definitely be useful, thanks :) Presumably
> you're adding the annotation?

Yes.
Comment 11 Emmanuele Bassi (:ebassi) 2018-02-11 14:23:17 UTC 
Cherry picked the commit to the gtk-3-22 branch, with the additional "Since" annotation.