After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792783 - omxvideoenc: drop late input frames
omxvideoenc: drop late input frames
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-22 13:29 UTC by Guillaume Desmottes
Modified: 2018-01-22 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omxvideoenc: drop late input frames (1.55 KB, patch)
2018-01-22 13:29 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2018-01-22 13:29:01 UTC 
.
Comment 1 Guillaume Desmottes 2018-01-22 13:29:35 UTC 
Created attachment 367217 [details] [review]
omxvideoenc: drop late input frames

Make use of the new GstVideoEncoder QoS API to drop late input frames. This may
help a live pipeline to catch up if it's being late and all frames end up
being dropped at the sink.
Comment 2 Nicolas Dufresne (ndufresne) 2018-01-22 14:40:10 UTC 
Review of attachment 367217 [details] [review]:

Is there a way to disable this ? Does the base class adds QoS boolean property?
Comment 3 Tim-Philipp Müller 2018-01-22 14:46:18 UTC 
Hrm, I thought there was a blocker bug about this.

I think there should be a property and it should be FALSE by default.
Comment 4 Tim-Philipp Müller 2018-01-22 14:47:15 UTC 
And it is, so all good :)
Comment 5 Guillaume Desmottes 2018-01-22 14:57:07 UTC 
Yes, this code should be no-op until user sets qos=true on the encoder. See https://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=7950a4614c7dce57c7505503ba3d78495f9344c4
Comment 6 Nicolas Dufresne (ndufresne) 2018-01-22 16:47:03 UTC 
Review of attachment 367217 [details] [review]:

Ok, no more comments then ;-P
Comment 7 Tim-Philipp Müller 2018-01-22 17:05:38 UTC 
commit 0c5bbbb6ca5ff9c262e8a45f0b7f6be9ed4e4213 (HEAD -> master)
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri Sep 22 16:02:40 2017 +0200

    omxvideoenc: drop late input frames if QoS is enabled
    
    Make use of the new GstVideoEncoder QoS API to drop late input frames. This may
    help a live pipeline to catch up if it's being late and all frames end up
    being dropped at the sink.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=792783