After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792762 - groovy.lang: fix highlighting for dollar slashy strings starting with /
groovy.lang: fix highlighting for dollar slashy strings starting with /
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
unspecified
Other All
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-21 20:41 UTC by Роман Донченко
Modified: 2018-01-24 09:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
groovy.lang: fix highlighting for dollar slashy strings starting with / (2.00 KB, patch)
2018-01-21 20:41 UTC, Роман Донченко 		committed Details | Review

Description Роман Донченко 2018-01-21 20:41:28 UTC 
The look-ahead assertion is wrong; what _actually_ can't follow `$/` is
not `/`, but `/$`. In other words, a dollar slashy string can't be empty.

Also, remove the comment about the requirements on the on the preceding
token, because those were removed in the in-development versions of Groovy
(not sure when exactly, but they're gone in 3.0.0-alpha-1).
Comment 1 Роман Донченко 2018-01-21 20:41:32 UTC 
Created attachment 367182 [details] [review]
groovy.lang: fix highlighting for dollar slashy strings starting with /
Comment 2 Sébastien Wilmet 2018-01-22 10:20:55 UTC 
Review of attachment 367182 [details] [review]:

++, thanks.
Comment 3 Sébastien Wilmet 2018-01-24 09:13:32 UTC 
Attachment 367182 [details] pushed as 1880e41 - groovy.lang: fix highlighting for dollar slashy strings starting with /