After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792760 - Scrollback lines +/- jump in bigger steps
Scrollback lines +/- jump in bigger steps
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: Profiles
git master
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-21 20:01 UTC by Egmont Koblinger
Modified: 2018-01-22 12:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (3.29 KB, patch)
2018-01-21 21:32 UTC, Egmont Koblinger 		committed Details | Review

Description Egmont Koblinger 2018-01-21 20:01:36 UTC 
Inspired by Guake 3's current behavior (see also https://github.com/Guake/guake/issues/1082):

Under Profile prefs -> Scrolling, the +/- buttons of scrollback lines could jump in bigger steps, let's say by 1000. In the current form (jumping by 1) these buttons are pretty unusable in practice.
Comment 1 Egmont Koblinger 2018-01-21 21:32:15 UTC 
Created attachment 367188 [details] [review]
Fix

What is page_increment? I randomly made up some numbers (just as for cell spacing not long ago), but I don't know how to achieve jumping by that amount :)

I've also squeezed in two more changes:

- Scrollback lines is already marked as "numeric", also mark the fields of the General tab as such. This disallows the input of non-digit characters. (The locale-specific decimal separator is also allowed wherever appropriate.)

- Removed climb_rate=1 which is probably there due to a misunderstanding that the value is 0-based and not 1-based, hence the value of 1 switches to double speed at one point during a long click which is probably more misleading than useful. (E.g. a value of 99 means that eventually the last two digits stop changing. Unfortunately the last 2 digits get stuck on a random value rather than being zeros, making this a useful but visually unpleasant feature.)