After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792740 - Memleak in search_rows() ?
Memleak in search_rows() ?
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-20 20:53 UTC by Egmont Koblinger
Modified: 2018-01-22 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix (1020 bytes, patch)
2018-01-20 20:57 UTC, Egmont Koblinger
committed Details | Review

Description Egmont Koblinger 2018-01-20 20:53:35 UTC
Haven't tested, just looking at the source:

search_rows() calls "row_text = get_text(...)", then has three places where it can "return false", leaving row_text un-g_string_free'd.
Comment 1 Egmont Koblinger 2018-01-20 20:57:32 UTC
Created attachment 367158 [details] [review]
Fix
Comment 2 Christian Persch 2018-01-20 23:09:02 UTC
Comment on attachment 367158 [details] [review]
Fix

Indeed. Thanks!
Comment 3 Egmont Koblinger 2018-01-22 12:41:36 UTC
Fixed.