After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792729 - Allow spaces in regexes
Allow spaces in regexes
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-20 14:45 UTC by Egmont Koblinger
Modified: 2018-01-31 22:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix? (852 bytes, patch)
2018-01-28 00:05 UTC, Egmont Koblinger
committed Details | Review

Description Egmont Koblinger 2018-01-20 14:45:07 UTC
Currently our regex matching code does some special treatment of spaces. I can't recall exactly what it is, but somehow it splits at spaces, or expects spaces not to match.

Spaces should not be treated in any special way, regex matching should happen on entire paragraphs (that is, stop at explicit newlines only).

---

Ubuntu has a patch to recognize launchpad bug numbers like lp: #1234567, with the regex (?i:lp: #)[[:digit:]]+".

When the mouse enters either "lp:" or "#1234567", the entire match is underlined and works as expected. However, if the mouse enters the space from above or below, the match is not recognized.

---

Guake (version 3) has a Quick open feature, and within that a "Quick open in current terminal" with a regex "^  File \".*\", line [0-9]+". Same story here. (This feature doesn't work at all, but that's their fault.)
Comment 1 Egmont Koblinger 2018-01-28 00:05:01 UTC
Created attachment 367541 [details] [review]
Fix?

I have no idea what I'm doing :-D

I've just removed all relevant occurrences that I could quickly find where space had special treatment, and it seems to work.
Comment 2 Egmont Koblinger 2018-01-31 22:02:15 UTC
Comment on attachment 367541 [details] [review]
Fix?

Committed.
Comment 3 Egmont Koblinger 2018-01-31 22:07:45 UTC
Comment on attachment 367541 [details] [review]
Fix?

Committed.