After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792723 - Can't reuse result when locale is fr_FR.utf8 (3.26.0)
Can't reuse result when locale is fr_FR.utf8 (3.26.0)
Status: RESOLVED DUPLICATE of bug 785107
Product: gnome-calculator
Classification: Core
Component: general
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-20 12:07 UTC by jean-baptiste
Modified: 2018-01-21 18:01 UTC
See Also:
GNOME target: ---
GNOME version: 3.25/3.26



Description jean-baptiste 2018-01-20 12:07:37 UTC
Hi,

it looks like the bug https://bugzilla.gnome.org/show_bug.cgi?id=785107 is still active in Fedora 27.

Here is the maintainer comment: https://bugzilla.redhat.com/show_bug.cgi?id=1536368

Did we misunderstood the commit ad694dba6d13633bb5a2ec6f41b3a3fe9758007d was included in 3.26.0 ?

Thanks for your help
Comment 1 Bastien Nocera 2018-01-20 12:30:45 UTC
Removing the depends
Comment 2 Robert Roth 2018-01-20 15:10:35 UTC
(In reply to jean-baptiste from comment #0)
> Here is the maintainer comment:
> https://bugzilla.redhat.com/show_bug.cgi?id=1536368
> 
> Did we misunderstood the commit ad694dba6d13633bb5a2ec6f41b3a3fe9758007d was
> included in 3.26.0 ?

The commit was the first one after the 3.26.0 release, so it was not included in 3.26.0. Backporting it to a 3.26.x version would probably need a freeze exception approval, as the commit includes help string changes (approval from i18n team), and, well, a feature change I guess, given that the used "ans" variable was renamed to "_".
Comment 3 Bastien Nocera 2018-01-21 00:24:06 UTC
$ git describe ad694dba6d13633bb5a2ec6f41b3a3fe9758007d
3.25.92-24-gad694dba

You forgot to tag the release :(
(or do a follow-up one, it's been broken since September)

Jean-Baptiste, I'll do a Fedora update Monday.

*** This bug has been marked as a duplicate of bug 785107 ***
Comment 4 Robert Roth 2018-01-21 11:01:05 UTC
(In reply to Bastien Nocera from comment #3)
> $ git describe ad694dba6d13633bb5a2ec6f41b3a3fe9758007d
> 3.25.92-24-gad694dba
> 
> You forgot to tag the release :(
Strange, the 3.26.0 release is tagged, there is https://git.gnome.org/browse/gnome-calculator/tag/?h=3.26.0.

> (or do a follow-up one, it's been broken since September)
Ok, I'll do a follow up release with this fix cherrypicked into the gnome-3-26 branch.
> 
> Jean-Baptiste, I'll do a Fedora update Monday.
> 
> *** This bug has been marked as a duplicate of bug 785107 ***
Comment 5 Bastien Nocera 2018-01-21 15:48:09 UTC
(In reply to Robert Roth from comment #4)
> (In reply to Bastien Nocera from comment #3)
> > $ git describe ad694dba6d13633bb5a2ec6f41b3a3fe9758007d
> > 3.25.92-24-gad694dba
> > 
> > You forgot to tag the release :(
> Strange, the 3.26.0 release is tagged, there is
> https://git.gnome.org/browse/gnome-calculator/tag/?h=3.26.0.

I really don't understand the reasoning behind branching before doing a release like this only to cherry-pick the changes for that release into another branch:
https://git.gnome.org/browse/gnome-calculator/commit/?h=3.26.0&id=b2d0bb15ec8618b0bfc2350d556b688086d4a3b9
https://git.gnome.org/browse/gnome-calculator/commit/?id=acef35162e558572a5e608951399048e51e5ca3a

Still, my fault for not checking this properly.