After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792711 - gdp: is broken for GST_EVENT_CUSTOM event types.
gdp: is broken for GST_EVENT_CUSTOM event types.
Status: RESOLVED DUPLICATE of bug 754119
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-20 06:01 UTC by Matt Gruenke
Modified: 2018-01-20 10:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matt Gruenke 2018-01-20 06:01:41 UTC
Refer to gstreamer/gst/gstevent.h, where all CUSTOM event types have a GstEventType >= (270 << 8).  This always results in values greater than 2^16, yet we see from gst-plugins-bad/gst/gdp/dataprotocol.c that gst_dp_event_from_packet_1_0() reads the GstEventType using GST_DP_HEADER_PAYLOAD_TYPE(), which is defined as GST_READ_UINT16_BE().  Consequently, any GST_EVENT_CUSTOM will deserialize with a bad type.

I'm not very familiar with dataprotocol, but it's not clear to me how this can be resolved without incrementing the dataprotocol version.

In future revisions of the protocol, I would suggest that serialization of any enums support values up to 32-bits.
Comment 1 Tim-Philipp Müller 2018-01-20 10:13:00 UTC

*** This bug has been marked as a duplicate of bug 754119 ***