After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792687 - workspaceThumbnail: only update _porthole if the overview is visible
workspaceThumbnail: only update _porthole if the overview is visible
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-19 15:41 UTC by Marco Trevisan (Treviño)
Modified: 2018-08-30 03:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspaceThumbnail: only update _porthole if the overview is visible (1.05 KB, patch)
2018-01-19 15:42 UTC, Marco Trevisan (Treviño) 		none Details | Review
workspaceThumbnail: rebuild thumbnails if workareas size changed (2.26 KB, patch)
2018-01-19 15:42 UTC, Marco Trevisan (Treviño) 		none Details | Review
workspaceThumbnail: initialize porthole based on workArea (1.38 KB, patch)
2018-01-19 16:38 UTC, Marco Trevisan (Treviño) 		none Details | Review

Description Marco Trevisan (Treviño) 2018-01-19 15:41:59 UTC 
Otherwise it happens that porthole is computed again after that the
overlay is hidden (triggered by a layout reallocation) and thus not
regenerated again afterwards.

Not a fan of _ensurePorthole() at all, I'd prefer just set it once,
but I preferred not to change this, let me know what you prefer.
Comment 1 Marco Trevisan (Treviño) 2018-01-19 15:42:05 UTC 
Created attachment 367088 [details] [review]
workspaceThumbnail: only update _porthole if the overview is visible

Otherwise it happens that porthole is computed again after that the
overlay is hidden (triggered by a layout reallocation) and thus not
regenerated again afterwards.
Comment 2 Marco Trevisan (Treviño) 2018-01-19 15:42:11 UTC 
Created attachment 367089 [details] [review]
workspaceThumbnail: rebuild thumbnails if workareas size changed
Comment 3 Marco Trevisan (Treviño) 2018-01-19 16:38:07 UTC 
Created attachment 367091 [details] [review]
workspaceThumbnail: initialize porthole based on workArea

Just a cleanup...
Comment 4 Jonas Ådahl 2018-08-19 12:53:51 UTC 
Reopening since the fix was reverted due to regressing the default setup.
Comment 5 Marco Trevisan (Treviño) 2018-08-30 03:51:01 UTC 
This was reverted only partially, and so far the reverted change (workspaceThumbnail: rebuild thumbnails if workareas size changed) doesn't seem to be needed anymore.