After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792660 - Broken parameter type checking for async methods
Broken parameter type checking for async methods
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Methods
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on: 644241
Blocks:
 
 
Reported: 2018-01-18 19:55 UTC by Rico Tzschichholz
Modified: 2018-01-18 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revert "Do not warn about non-default parameters for coroutines." (2.03 KB, patch)
2018-01-18 19:55 UTC, Rico Tzschichholz 		committed Details | Review
tests: Add test for parameter type checking of async methods (1.35 KB, patch)
2018-01-18 20:02 UTC, Rico Tzschichholz 		committed Details | Review

Description Rico Tzschichholz 2018-01-18 19:55:33 UTC 
This is a regression caused by dd24a1bfe1a78bf1a37d35f5d8dd6480fd4a8941
Comment 1 Rico Tzschichholz 2018-01-18 19:55:41 UTC 
Created attachment 367039 [details] [review]
Revert "Do not warn about non-default parameters for coroutines."

Breaks parameter inference for async method overrides.

This reverts commit dd24a1bfe1a78bf1a37d35f5d8dd6480fd4a8941.
Comment 2 Rico Tzschichholz 2018-01-18 20:02:23 UTC 
Created attachment 367041 [details] [review]
tests: Add test for parameter type checking of async methods
Comment 3 Rico Tzschichholz 2018-01-18 20:24:59 UTC 
Attachment 367039 [details] pushed as 5573992 - Revert "Do not warn about non-default parameters for coroutines."
Attachment 367041 [details] pushed as 71ffab1 - tests: Add test for parameter type checking of async methods