After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792645 - basetransform: set_passthrough() not doing what the doc says
basetransform: set_passthrough() not doing what the doc says
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-18 14:36 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-11-03 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nicolas Dufresne (ndufresne) 2018-01-18 14:36:31 UTC 
The doc says:

 * Always %TRUE for filters which don't implement either a transform
 * or transform_ip method.

While the implementation is no-op in the case we pass FALSE and that conditions is met:

  >if (!passthrough) {
  >  if (bclass->transform_ip || bclass->transform)
  >    trans->priv->passthrough = FALSE;
  >} else {
  >  trans->priv->passthrough = TRUE;
  >}

It's also a weird condition to check for filters that only wants to implement submit_input_buffer() and generate_output(), as they need to place a useless stub for one of the transform function in order to make it behave properly.
Comment 1 GStreamer system administrator 2018-11-03 12:44:33 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/271.