After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792641 - Re-add autotools requirements to meson build
Re-add autotools requirements to meson build
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-18 12:17 UTC by Bastien Nocera
Modified: 2018-01-23 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Make bluetooth, network and wacom mandatory on linux (8.43 KB, patch)
2018-01-18 15:22 UTC, Iñigo Martínez 		none Details | Review
build: Make network mandatory on every linux (5.81 KB, patch)
2018-01-23 11:25 UTC, Iñigo Martínez 		none Details | Review
build: Make network mandatory on every linux (5.90 KB, patch)
2018-01-23 11:57 UTC, Iñigo Martínez 		accepted-commit_now Details | Review

Description Bastien Nocera 2018-01-18 12:17:15 UTC 
On Linux machines, the wacom, bluetooth and network panels should not be optional. The wacom and bluetooth panels should however not be enabled on s390 systems, which lack USB support.

Other systems won't support those panels at all, so building them should not be attempted either.
Comment 1 Iñigo Martínez 2018-01-18 15:22:31 UTC 
Created attachment 367021 [details] [review]
build: Make bluetooth, network and wacom mandatory on linux

This patch makes these three panels mandatory on linux, except on s390 systems.

In other platforms these are not built at all.
Comment 2 Georges Basile Stavracas Neto 2018-01-23 01:13:43 UTC 
Review of attachment 367021 [details] [review]:

Looks good, and works. Thanks!
Comment 3 Georges Basile Stavracas Neto 2018-01-23 01:15:11 UTC 
Review of attachment 367021 [details] [review]:

Looks good, and works. Thanks!
Comment 4 Georges Basile Stavracas Neto 2018-01-23 01:15:11 UTC 
Review of attachment 367021 [details] [review]:

Looks good, and works. Thanks!
Comment 5 Georges Basile Stavracas Neto 2018-01-23 01:15:50 UTC 
Thanks for the patch.

Attachment 367021 [details] pushed as a2b20a6 - build: Make bluetooth, network and wacom mandatory on linux
Comment 6 Bastien Nocera 2018-01-23 10:17:48 UTC 
Review of attachment 367021 [details] [review]:

::: meson.build
@@ +180,3 @@
+
+if host_is_s390
+  message('Bluetooth, Network and Wacom panels will not be built (no USB support on this platform)')

The Network panel should be built on s390.

@@ +183,3 @@
+endif
+
+enable_linux = host_is_linux and not host_is_s390

As per above, this is the wrong check.
Comment 7 Georges Basile Stavracas Neto 2018-01-23 11:10:16 UTC 
Right; I misunderstood the requirements of this task. Let's fix that.
Comment 8 Bastien Nocera 2018-01-23 11:13:29 UTC 
Bluetooth, Wacom: enabled on every Linux except s390, disabled on every non-Linux
Network: enabled on every Linux, disabled on every non-Linux
Comment 9 Iñigo Martínez 2018-01-23 11:25:41 UTC 
Created attachment 367294 [details] [review]
build: Make network mandatory on every linux

Yes I also misunderstood the requirements. Hope this patch update fixes this.
Comment 10 Iñigo Martínez 2018-01-23 11:57:31 UTC 
Created attachment 367295 [details] [review]
build: Make network mandatory on every linux

Just a minor improvement by removing the `host_is_s390` variable which is unnecessary now.
Comment 11 Georges Basile Stavracas Neto 2018-01-23 14:44:58 UTC 
Review of attachment 367295 [details] [review]:

Passed code review, thanks for quickly fixing that!
Comment 12 Georges Basile Stavracas Neto 2018-01-23 14:46:37 UTC 
This should be properly fixed now. Please reopen if the criteria is still not correct.

Attachment 367295 [details] pushed as 3afdaa3 - build: Make network mandatory on every linux
Comment 13 Bastien Nocera 2018-01-23 14:48:10 UTC 
Review of attachment 367295 [details] [review]:

Looks good.
Comment 14 Bastien Nocera 2018-01-23 14:49:14 UTC 
Guess I'm late to the party ;)