GNOME Bugzilla – Bug 792567
Individual.display_name: don't fallback on persona's display_id if it equals the IID
Last modified: 2018-01-22 12:20:23 UTC
Right now, we use the display_id of the Persona's in an Individual as a fallback for the display_name. This might make sense for e.g. Tpf.Persona's where the display_id is really the identifier. However: for other types persona's (like from E-D-S), this will fall back to the Persona's IID, which we really don't want to display to the user. So we either: * Don't use the display-id as a fallback property * Check in `_look_up_display_id_for_display_name()` whether the persona's display name equals its IID, and if so, to not use it. Philip: any opinions about this?
(In reply to Niels De Graef from comment #0) > * Check in `_look_up_display_id_for_display_name()` whether the persona's > display name equals its IID, and if so, to not use it. That seems like a reasonable thing to do.
Created attachment 367180 [details] [review] Individual: don't always use the display_id. Sometimes, a Persona's display_id will fall back to the IID, which we really don't want to show as a display name. Fixes bug 792567 (https://bugzilla.gnome.org/show_bug.cgi?id=792567).
Review of attachment 367180 [details] [review]: ++
Attachment 367180 [details] pushed as 84b78da - Individual: don't always use the display_id.