After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792538 - epub: Update for API changes
epub: Update for API changes
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: books
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Books Maintainers
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-01-15 17:26 UTC by Bastien Nocera
Modified: 2018-01-17 16:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
epub: Update for API changes (2.78 KB, patch)
2018-01-15 17:26 UTC, Bastien Nocera 		none Details | Review
epub: Updated epub version (1.22 KB, patch)
2018-01-17 12:08 UTC, Daniel Garcia 		none Details | Review
epub: Update for API changes (3.68 KB, patch)
2018-01-17 16:33 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2018-01-15 17:26:04 UTC 
.
Comment 1 Bastien Nocera 2018-01-15 17:26:07 UTC 
Created attachment 366853 [details] [review]
epub: Update for API changes

See https://gitlab.gnome.org/GNOME/libgepub/merge_requests/2
Comment 2 Bastien Nocera 2018-01-15 17:26:49 UTC 
Note that the MR was reverted for now.
Comment 3 Bastien Nocera 2018-01-15 17:47:06 UTC 
And that there's probably a bug in this patch, or the original MR, as we can't move beyond the first page.
Comment 4 Daniel Garcia 2018-01-17 11:09:25 UTC 
I've just fixed the problem [1]. Now this should work correctly. By the way, I'm changing the version number because the api break so this patch should also update from Gepub-0.5 to Gepub-0.6.

[1] https://gitlab.gnome.org/GNOME/libgepub/commit/e2055cfac5bd53bdcf9d752f34a5800eecf76c7c
Comment 5 Daniel Garcia 2018-01-17 12:08:30 UTC 
Created attachment 366931 [details] [review]
epub: Updated epub version
Comment 6 Daniel Garcia 2018-01-17 12:09:22 UTC 
I've just added a new patch to update the libgepub version. I've tested it locally and it works with the master libgepub version.
Comment 7 Bastien Nocera 2018-01-17 16:33:40 UTC 
Created attachment 366953 [details] [review]
epub: Update for API changes

See https://gitlab.gnome.org/GNOME/libgepub/merge_requests/2
Comment 8 Bastien Nocera 2018-01-17 16:34:32 UTC 
I integrated Daniel's patch into the original one as well.

Attachment 366953 [details] pushed as 739145b - epub: Update for API changes