After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792498 - Shotwell 0.27.2 segfaults when adding webdav paths to database
Shotwell 0.27.2 segfaults when adding webdav paths to database
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: alt-filesystem
0.27.x
Other Linux
: Normal normal
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-13 16:54 UTC by Aaron Caskey-Demaret
Modified: 2018-01-13 20:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdb log when importing (5.99 KB, text/plain)
2018-01-13 16:54 UTC, Aaron Caskey-Demaret 		  Details
gdb log when starting after initial import (5.99 KB, text/plain)
2018-01-13 16:55 UTC, Aaron Caskey-Demaret 		  Details
ACTUALLY gdb log when starting after initial import (3.71 KB, text/plain)
2018-01-13 16:57 UTC, Aaron Caskey-Demaret 		  Details
Shotwell Database Archive (3 images all residing on webdav locations) (66.21 KB, application/gzip)
2018-01-13 17:04 UTC, Aaron Caskey-Demaret 		  Details
Fix folder sidebar with DAV (1.15 KB, patch)
2018-01-13 20:50 UTC, Jens Georg 		committed Details | Review

Description Aaron Caskey-Demaret 2018-01-13 16:54:01 UTC 
Created attachment 366769 [details]
gdb log when importing

#750529 and #740436 may be related to this.

On Ubuntu 17.10 I'm trying to import in place some files on a webdav server (nextcloud 12)

They seem to import okay, with the images flashing passed briefly as they are processed, but then shotwell will segfault.

Trying to start shotwell after will segfault.
Comment 1 Aaron Caskey-Demaret 2018-01-13 16:55:00 UTC 
Created attachment 366770 [details]
gdb log when starting after initial import
Comment 2 Aaron Caskey-Demaret 2018-01-13 16:57:25 UTC 
Created attachment 366771 [details]
ACTUALLY gdb log when starting after initial import
Comment 3 Aaron Caskey-Demaret 2018-01-13 17:04:02 UTC 
Created attachment 366772 [details]
Shotwell Database Archive (3 images all residing on webdav locations)
Comment 4 Aaron Caskey-Demaret 2018-01-13 17:12:36 UTC 
I just tried with an sftp location, in case it was a gvfs error and not specific to webdav. But that worked fine.

No issues importing and then saving tags to a file over sftp.
Comment 5 Jens Georg 2018-01-13 18:57:40 UTC 
Can reproduce here. Really odd.
Comment 6 Jens Georg 2018-01-13 19:03:19 UTC 



+
Trace
    238333






    

  • 
#2
folders_sidebar_entry_construct

    
                at /home/jens/Source/shotwell/src/folders/FoldersBranch.vala
                  line
                  171

    

    • 







$1 = (GFile *) 0x5555560e0c40
(gdb) call g_file_get_path($1)
$2 = 0x0
(gdb) call g_file_get_uri($1)
$3 = 0x555555d75390 "davs://jgeorg@home.jensgeorg.de/"
(gdb) 

Issue is that the root node of a davs uri does not seem to have a path available, since it is only mounted some levels below.






Comment 7


Jens Georg





          2018-01-13 20:50:15 UTC
        



Created attachment 366779 [details] [review]
Fix folder sidebar with DAV

Shotwell tried to go up to the root folder, but if a concrete path is
mounted, the parent might not have a path associated

So we stop if there is either no parent or the parent does not have a
local mount representation






Comment 8


Jens Georg





          2018-01-13 20:58:10 UTC
        



Attachment 366779 [details] pushed as 1786a3a - Fix folder sidebar with DAV