After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792448 - smoothstreaming: fix H264 CodecPrivateData parsing, need to skip NALU type when using gst_h264_parse_sps()
smoothstreaming: fix H264 CodecPrivateData parsing, need to skip NALU type wh...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-12 05:15 UTC by yychao
Modified: 2018-11-03 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
smoothstreaming-fix-H264-CodecPrivateData-parsing-ne.patch (1.26 KB, application/mbox)
2018-01-12 05:15 UTC, yychao 		  Details
0002-smoothstreaming-fix-H264-CodecPrivateData-parsing-ne.patch (1.26 KB, patch)
2018-01-12 06:32 UTC, yychao 		none Details | Review

Description yychao 2018-01-12 05:15:58 UTC 
Created attachment 366694 [details]
smoothstreaming-fix-H264-CodecPrivateData-parsing-ne.patch

gstmssmanifest.c use function _gst_mss_stream_add_h264_codec_data() to parse
the H264CodecPrivateData. But gst_h264_video_calculate_framerate() might get
an incorrect framerate, because SPS NALU type(0x67) was forgot to skip by
using gst_h264_parse_sps() to do the parsing.
Comment 1 yychao 2018-01-12 06:32:25 UTC 
Created attachment 366698 [details] [review]
0002-smoothstreaming-fix-H264-CodecPrivateData-parsing-ne.patch

Sorry, there was a typo in 00001-smoothstreaming-fix-H264-CodecPrivateData-parsing-ne.patch, 0x67 is only one byte. Please use 0002-smoothstreaming-fix-H264-CodecPrivateData-parsing-ne.patch instead.
Comment 2 yychao 2018-01-19 04:52:08 UTC 
For more detail, try to visit following page.

gst-launch-1.0 playbin uri=http://playready.directtaps.net/smoothstreaming/SSWSS720H264/SuperSpeedway_720.ism/Manifest

When resolution change to 358x208, incorrect framerate will introduce "Internal data stream error".

    <QualityLevel
      Index="5"
      Bitrate="477000"
      FourCC="H264"
      MaxWidth="368"
      MaxHeight="208"
      CodecPrivateData="000000016764000DAC2CA505C6EFFC10000FED48303032000007D200017700C04003A3A0003A3A7F8C718080074740007474FF18E1DA1225160000000168E9093525" />
Comment 3 GStreamer system administrator 2018-11-03 14:17:23 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/648.