After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792409 - power: Don't react to light changes if not at console
power: Don't react to light changes if not at console
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-10 17:05 UTC by Bastien Nocera
Modified: 2018-01-12 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
power: Don't react to light changes if not at console (2.42 KB, patch)
2018-01-10 17:05 UTC, Bastien Nocera 		none Details | Review
power: Don't react to light changes if not at console (3.05 KB, patch)
2018-01-10 17:18 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2018-01-10 17:05:25 UTC 
.
Comment 1 Bastien Nocera 2018-01-10 17:05:29 UTC 
Created attachment 366606 [details] [review]
power: Don't react to light changes if not at console

As iio-sensor-proxy isn't yet clever enough to only send property
changes signals to clients that have claimed a sensor, disconnect
the properties-changed signal so we don't attempt to make brightness
changes when we're not on the active seat.

See https://github.com/hadess/iio-sensor-proxy/issues/210
See https://bugzilla.gnome.org/show_bug.cgi?id=756539
See https://bugzilla.gnome.org/show_bug.cgi?id=773685
See https://bugzilla.gnome.org/show_bug.cgi?id=764896
Comment 2 Bastien Nocera 2018-01-10 17:18:16 UTC 
Created attachment 366608 [details] [review]
power: Don't react to light changes if not at console

As iio-sensor-proxy isn't yet clever enough to only send property
changes signals to clients that have claimed a sensor, disconnect
the properties-changed signal so we don't attempt to make brightness
changes when we're not on the active seat.

See https://github.com/hadess/iio-sensor-proxy/issues/210
See https://bugzilla.gnome.org/show_bug.cgi?id=756539
See https://bugzilla.gnome.org/show_bug.cgi?id=773685
See https://bugzilla.gnome.org/show_bug.cgi?id=764896
See https://bugzilla.redhat.com/show_bug.cgi?id=1322588
Comment 3 Bastien Nocera 2018-01-12 15:07:21 UTC 
Pushed to master. Will be backported all the way to GNOME 3.24 as well.

Attachment 366608 [details] pushed as bc732cd - power: Don't react to light changes if not at console