After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792331 - High CPU load after mounts changes
High CPU load after mounts changes
Status: RESOLVED OBSOLETE
Product: gvfs
Classification: Core
Component: trash backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Allison Karlitskaya (desrt)
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-08 15:41 UTC by Ondrej Holy
Modified: 2018-02-01 11:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
trash: Rate limit mounts_changed signal (3.43 KB, patch)
2018-01-08 15:44 UTC, Ondrej Holy 		none Details | Review

Description Ondrej Holy 2018-01-08 15:41:42 UTC 
This is part of my effort to reduce CPU load during mass changes of mounts...
Comment 1 Ondrej Holy 2018-01-08 15:43:33 UTC 
See bug for g-s-d:
https://bugzilla.gnome.org/show_bug.cgi?id=792235
Comment 2 Ondrej Holy 2018-01-08 15:44:11 UTC 
Created attachment 366495 [details] [review]
trash: Rate limit mounts_changed signal

The gvfsd-trash daemon can cause high CPU load for a quite long time
in situations when it recieved a big amount of mount_changed signals
within a short time. This can easily happen in enterprise environments
where autofs mounts are havily used. Use g_unix_mounts_changed_since to
check whether the mounts changed since the last check to prevents high
CPU load after the last real change, because the processing is slow
and the daemon is not able to handle the signals in real time. Also
let's limit the number of checks per time to reduce CPU load.
Comment 3 Ondrej Holy 2018-01-08 16:48:42 UTC 
See also trash monitor improvements:
https://gitlab.gnome.org/GNOME/nautilus/merge_requests/57
https://bugzilla.gnome.org/show_bug.cgi?id=792331
Comment 4 Ondrej Holy 2018-02-01 11:33:02 UTC 
Was hopefully fixed by:
https://bugzilla.gnome.org/show_bug.cgi?id=793006